Code review comment for lp:~thedac/charms/precise/rabbitmq-server/enable-nrpe-external-master

Revision history for this message
Tom Haddon (mthaddon) wrote :

I think we should change the author of the check_rabbitmq.py script, as that email address no longer works (the person in question has left Canonical). Also I wonder if we can change the NAGIOS_PLUGINS='/usr/lib/nagios/plugins' to NAGIOS_PLUGINS='/usr/local/lib/nagios/plugins' - it seems odd to install non-packaged files in /usr/lib. I think we may need to pre-create the directory, though.

review: Needs Fixing

« Back to merge proposal