Charm Helpers

Code review comment for lp:~thedac/charm-helpers/os-snaps

  1. os-snaps
  2. Merge into devel
Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

Please see inline comments.

Also, are there no tests for the new functions? I see patches to some of the existing tests for patching out the snaps existence test, but not for the new functions.

(I picked 'needs information' rather than 'needs fixing' because I'm not sure about the design aspect of passing in the post_snap function).

review: Needs Information

« Back to merge proposal