snappy-hwe-snaps

Code review comment for ~the-meulengracht/snappy-hwe-snaps/+git/jenkins-jobs:master

  1. Git
  2. lp:~the-meulengracht/snappy-hwe-snaps/+git/jenkins-jobs
  3. master
  4. Merge into master
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Thanks for this! I've a couple of comments.

Also, I have run flake8 on the python scripts, that should help to find issues in the migration to python3. See https://paste.ubuntu.com/p/cBMsq89xvZ/ . I think most things are harmless, except maybe:

./tools/vote-on-merge-proposal.py:76:10: E999 SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?

Anyway, it is a good opportunity to clean-up these warnings, although maybe you can ignore the "line too long" ones.

« Back to merge proposal