Merge lp:~tfukushima/glance/colorized-log into lp:~glance-coresec/glance/cactus-trunk
Proposed by
Taku Fukushima
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jay Pipes | ||||
Approved revision: | 88 | ||||
Merged at revision: | 88 | ||||
Proposed branch: | lp:~tfukushima/glance/colorized-log | ||||
Merge into: | lp:~glance-coresec/glance/cactus-trunk | ||||
Diff against target: |
238 lines (+213/-0) 1 file modified
run_tests.py (+213/-0) |
||||
To merge this branch: | bzr merge lp:~tfukushima/glance/colorized-log | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jay Pipes (community) | Approve | ||
Rick Harris | Pending | ||
Review via email: mp+53444@code.launchpad.net |
Description of the change
I stole the colorized code from nova.
To post a comment you must log in.
Hi Taku!
Thanks for adding some colour into our lives! :)
One little thing that I would guess is also a mistake in the original code, too:
234 + stream.wirte('E')
Correct that little typo and I'm good to approve this.
-jay