Code review comment for lp:~tes/goby/time_fix

Revision history for this message
Chris Murphy (chrismurf) wrote :

1) util/time.h still #includes <ctime>, but compiles fine without it. Probably okay to remove it, or is there a dependency I didn't see?

2) seems reasonable to me. I'll probably just do a 'using namespace goby' 99% of the time, but I can live with that. Consistent naming is a good thing.

3) looks good from a quick review.

4) did not review.

5) agreed.

 - c

review: Approve

« Back to merge proposal