Code review comment for lp:~termie/nova/libvirt_snapshot

Very nice. I think this a huge win to get into cactus. One issue with the metadata. There was a recent change to glance to use image_format and container_format instead of type. Type is now a property. I think you therefore need metadata like the following:

metadata = {'disk_format': base['disk_format'],
            'container_format': base['container_format'],
            'is_public': False,
            'properties': {'architecture': base['architecture'],
                           'type': base['type'], # or 'machine' if you prefer
...
There is also an optional 'name' which could perhaps be something like:
            'name': '%s.%s' (base['name'], snapshot['name'])
although I'm not super attached to that.