Merge lp:~ter0/scratch/fix-1097443 into lp:~elementary-apps/scratch/scratch

Proposed by Chris Johns
Status: Merged
Approved by: Mario Guerriero
Approved revision: 972
Merged at revision: 980
Proposed branch: lp:~ter0/scratch/fix-1097443
Merge into: lp:~elementary-apps/scratch/scratch
Diff against target: 11 lines (+1/-1)
1 file modified
src/Dialogs/WarnDialog.vala (+1/-1)
To merge this branch: bzr merge lp:~ter0/scratch/fix-1097443
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+142485@code.launchpad.net

Description of the change

Fixes bug. Also cleans up a lot of obsolete strings.

To post a comment you must log in.
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

you should edit the string in the warning dialog class too. Also don't edit translations manually but keep them handled by launchpad. So you should revert you changes and change the string into the vala class for warning dialogs. Then you will be able to change translations directly from launchpad.

Revision history for this message
Cody Garver (codygarver) wrote :

Mario, the way we update translations is:

cd scratch
cd build
cmake ..
make pot
cd ../
bzr commit -m "Update translations."

Are you doing it another way?

Revision history for this message
Chris Johns (ter0) wrote :

Thanks for the help guys. The method Cody suggests generates
scratch-text-editor.pot, but the one in the branch already was just
scratch.pot?

On 9 January 2013 16:51, Cody Garver <email address hidden> wrote:

> Mario, the way we update translations is:
>
> cd scratch
> cd build
> cmake ..
> make pot
> cd ../
> bzr commit -m "Update translations."
>
> Are you doing it another way?
> --
> https://code.launchpad.net/~ter0/scratch/fix-1097443/+merge/142485
> You are the owner of lp:~ter0/scratch/fix-1097443.
>

lp:~ter0/scratch/fix-1097443 updated
972. By Chris Johns

Changed label text.

Revision history for this message
Cody Garver (codygarver) wrote :

Chris, it's probably best if you ignore translations. Thanks for the fix!

Mario, make pot is how we manage all the other translation updates so you should consider checking it out.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Dialogs/WarnDialog.vala'
2--- src/Dialogs/WarnDialog.vala 2012-08-03 09:37:11 +0000
3+++ src/Dialogs/WarnDialog.vala 2013-01-09 17:31:23 +0000
4@@ -57,7 +57,7 @@
5 text = ("<b>" + _("The file %s was deleted.") + "</b>").printf(filename);
6 text += "\n\n" + _("Do you want to create it again?");
7
8- add_button (Stock.YES, ResponseType.ACCEPT);
9+ add_button (_("Recreate"), ResponseType.ACCEPT);
10 add_button (Stock.CLOSE, ResponseType.CANCEL);
11 }
12

Subscribers

People subscribed via source and target branches