Merge ~teknoraver/snappy-hwe-snaps/+git/engineering-tests:master into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

Proposed by Matteo Croce
Status: Merged
Approved by: Simon Fels
Approved revision: 5fd3d480b758cdad01431e05556c7119f402328f
Merged at revision: 1a8c6a59cd1b472b5e5580fe7a2d9638def77533
Proposed branch: ~teknoraver/snappy-hwe-snaps/+git/engineering-tests:master
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 36 lines (+8/-9)
1 file modified
wifi-ap/units/wifi-ap.pxu (+8/-9)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Needs Fixing
Jim Hodapp Pending
Review via email: mp+314090@code.launchpad.net

This proposal supersedes a proposal from 2017-01-04.

Description of the change

Update test for new interfaces

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote : Posted in a previous version of this proposal

This MR needs a description set above. One minor fix inline below.

review: Needs Fixing
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

Three minor things inline.

review: Needs Fixing
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/wifi-ap/units/wifi-ap.pxu b/wifi-ap/units/wifi-ap.pxu
index ae198ef..affa766 100644
--- a/wifi-ap/units/wifi-ap.pxu
+++ b/wifi-ap/units/wifi-ap.pxu
@@ -14,23 +14,22 @@ category_id: wifi_ap
14_description: Ensure that the wifi_ap interfaces are connected14_description: Ensure that the wifi_ap interfaces are connected
15plugin: manual15plugin: manual
16_steps:16_steps:
17 1. Connect required wifi_ap slots/plugs17 1. Network Manager setup
18 .
19 $ sudo snap connect wifi-ap:firewall-control ubuntu-core:firewall-control
20 $ sudo snap connect wifi-ap:network-control ubuntu-core:network-control
21 .18 .
22 For snaps on Classic:19 For snaps on Classic:
23 $ sudo snap connect wifi-ap:network-manager ubuntu-core:network-manager20 NetworkManager is part of the base Ubuntu Desktop system
21 and does not need to be installed again.
24 .22 .
25 For full-snap based system (note that you need to install first23 For an Ubuntu Core system you have to install
26 network-manager snap in this case):24 the NetworkManager snap from the Ubuntu store.
27 $ sudo snap install network-manager25 $ sudo snap install network-manager
28 $ sudo snap connect wifi-ap:network-manager network-manager:service
29 .26 .
30_verification:27_verification:
31 Verify that you see the following when running snap interfaces:28 Verify that you see the following when running snap interfaces:
32 :network-bind wifi-ap29 :firewall-control wifi-ap
33 :network-control wifi-ap30 :network-control wifi-ap
31 :network wifi-ap
32 :network-bind wifi-ap
34 .33 .
35 For snaps on Classic:34 For snaps on Classic:
36 :network-manager wifi-ap35 :network-manager wifi-ap

Subscribers

People subscribed via source and target branches

to all changes: