Code review comment for lp:~teknico/charms/precise/juju-gui/integrate-builtin-server

Reviewers: mp+177907_code.launchpad.net,

Message:
Please take a look.

Description:
Integrate the built-in server into the charm.

Add a "builtin-server" option to config.yaml, defaulting to false, to
enable
a new Tornado-based built-in web server, in place of haproxy and Apache
(still
the default).

Add a "guiserver.conf" Upstart config file, generated via a template.

Add a BuiltinServerMixin to hooks/backend.py .

Factor out common code betwenn HaproxyApacheMixin and
BuiltinServerMixin.

Rename options.http to options.insecure in server/guiserver/manage.py .

Integrate testing of TestBackendCommands in TestBackendCommands.

Add a test for write_builtin_server_startup.

Miscellaneuos cleanup.

Please QA by setting "builtin-server" to true in config.yaml and
deploying
with "make deploy" (after bootstrapping), see "make help".

https://code.launchpad.net/~teknico/charms/precise/juju-gui/integrate-builtin-server/+merge/177907

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/12086044/

Affected files:
   M Operation.md
   A [revision details]
   M config.yaml
   A config/guiserver.conf.template
   A deps/tornado-3.1.tar.gz
   M hooks/backend.py
   M hooks/utils.py
   M server/guiserver/manage.py
   M server/guiserver/tests/test_manage.py
   M server/runserver.py
   M tests/test_backends.py
   M tests/test_utils.py