Merge lp:~teemperor/pantheon-greeter/symbolic-icons-for-entries into lp:~elementary-pantheon/pantheon-greeter/trunk

[Raphael Isemann]

Add primary icon to indicate field type

Manual login is a bit confusing without any indication what kind of input we expect from the user. Not sure if it is too overloaded with both a primary and secondary icon.

[Robert Roth (evfool)]

The code looks fine, but an UX review is required for this, maybe posting a screenshot for them would help (simply to avoid the hassle of compiling and installing and testing a new greeter)

review: Approve (code)

[Raphael Isemann (teemperor)]

You don't need to install the greeter anymore, just launch the compiled
binary :)
Am 06.11.2014 08:39 schrieb "Robert Roth" <email address hidden>:

> Review: Approve code
>
> The code looks fine, but an UX review is required for this, maybe posting
> a screenshot for them would help (simply to avoid the hassle of compiling
> and installing and testing a new greeter)
> --
>
> https://code.launchpad.net/~teemperor/pantheon-greeter/symbolic-icons-for-entries/+merge/239667
> You are the owner of
> lp:~teemperor/pantheon-greeter/symbolic-icons-for-entries.
>

[Cody Garver (codygarver)]

Screenshot gallery: http://imgur.com/qTP1YXY,0tYxiwr

=== modified file 'src/CredentialsArea.vala'
--- src/CredentialsArea.vala	2014-10-09 15:59:21 +0000
+++ src/CredentialsArea.vala	2014-10-26 19:36:59 +0000
@@ -38,6 +38,8 @@
         password = new Entry ();
         password.margin_top = 32;
 
+        password.set_icon_from_icon_name (Gtk.EntryIconPosition.PRIMARY, 
+                "dialog-password-symbolic");
         password.caps_lock_warning = true;
         //replace the letters with dots
         password.set_visibility (false);
@@ -90,4 +92,4 @@
     public override void pass_focus () {
         login_btn.grab_focus ();
     }
-}
\ No newline at end of file
+}

=== modified file 'src/LoginBox.vala'
--- src/LoginBox.vala	2014-10-21 19:29:37 +0000
+++ src/LoginBox.vala	2014-10-26 19:36:59 +0000
@@ -328,6 +328,8 @@
                 login_name_entry.sensitive = false;
             });
             login_name_entry = new Entry ();
+            login_name_entry.set_icon_from_icon_name (Gtk.EntryIconPosition.PRIMARY,
+                    "avatar-default-symbolic");
             login_name_entry.hexpand = true;
             login_name_entry.margin_top = 8;
             login_name_entry.set_icon_from_icon_name (Gtk.EntryIconPosition.SECONDARY, "go-jump-symbolic");
@@ -440,4 +442,4 @@
         }
 
     }
-}
\ No newline at end of file
+}