Code review comment for lp:~ted/whoopsie/ftbfs-network-manager

On Wed, 2016-05-11 at 06:13 +0000, Martin Pitt wrote:
> - whoopsie currently depends on network-manager-dev, which is (only)
> needed for compiling NM plugins such as VPN. I don't think that
> whoopsie actually needs that. - Your Makefile now adds a dependency
> to libnm-glib which does not get reflected in the Build-Depends. Note
> that network-manager-dev does *not* pull in libnm-glib-dev (and
> should not).
My goal here wasn't to fix Whoopsie :-)  Whoopsie uses the NM headers
to get a bunch of #defines for checking connectivity. I think it should
really probably just use the lib. But eh. Switched to the
NetworkManager.pc which is in that package but sets up the includes
correctly.
> - Why does this add a dep to libgcrypt20-dev? This seems completely
> unrelated; if libnm-glib-dev needs the gcrypt headers, that should
> depend on them, not libwhoopsie-dev. If this is necessary for an
> unrelated reason, then the commit log should explain.
It turns out the pkgconfig file for libwhoopsie does a "-lgcrypt" which
makes it break if you just pull it whoopsie and aren't using gcrypt.
Adding to description.