Code review comment for lp:~ted/whoopsie/ftbfs-network-manager

Revision history for this message
Martin Pitt (pitti) wrote :

This looks inconsistent:

 - whoopsie currently depends on network-manager-dev, which is (only) needed for compiling NM plugins such as VPN. I don't think that whoopsie actually needs that.
 - Your Makefile now adds a dependency to libnm-glib which does not get reflected in the Build-Depends. Note that network-manager-dev does *not* pull in libnm-glib-dev (and should not).
 - Why does this add a dep to libgcrypt20-dev? This seems completely unrelated; if libnm-glib-dev needs the gcrypt headers, that should depend on them, not libwhoopsie-dev. If this is necessary for an unrelated reason, then the commit log should explain.

Thanks!

review: Needs Fixing

« Back to merge proposal