Code review comment for lp:~ted/url-dispatcher/recoverable-inserts

Revision history for this message
Charles Kerr (charlesk) wrote :

The patch looks fine; approving.

As an aside, a couple of things stand out to me when reading this:

1. The scaffolding for building the key/value pairs is kind of clumsy. When we create a 'standard' version of recoverable errors and remove the copied files from the various projects, maybe report_recoverable_problem() should end in a ... with an __attribute__ ((__sentinel__)) in the prototype.

2. I'm surprised I hadn't noticed this before, but "motification"? :-)

review: Approve

« Back to merge proposal