Code review comment for lp:~ted/url-dispatcher/more-sophisticated-urls

Revision history for this message
Charles Kerr (charlesk) wrote :

The patch LGTM.

I don't know how common tel:/// is and at first glance it doesn't seem to conform to RFC 3966... unless there's at least some anecdotal evidence that tel:/// is frequent in the wild, I'd vote against it.

Ted, looks like this MP predates the branching your scripts did last week. Does this need to be submitted against /14.10 as well?

review: Approve

« Back to merge proposal