Merge lp:~ted/upstart/flip-edges into lp:upstart

Proposed by Ted Gould
Status: Merged
Merged at revision: 1497
Proposed branch: lp:~ted/upstart/flip-edges
Merge into: lp:upstart
Diff against target: 35 lines (+8/-8)
1 file modified
scripts/initctl2dot.py (+8/-8)
To merge this branch: bzr merge lp:~ted/upstart/flip-edges
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Review via email: mp+172145@code.launchpad.net

Commit message

Flip edges to fix Graphviz rankings

Description of the change

Change the edges of the Graphviz graph so that Graphviz can figure out the rankings of the various items and generate a better diagram.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Indeed the new diagram is much better. It now displays upstart view of proactive triggering of jobs left-to-right.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'scripts/initctl2dot.py'
--- scripts/initctl2dot.py 2013-03-22 13:50:30 +0000
+++ scripts/initctl2dot.py 2013-06-28 20:19:25 +0000
@@ -264,23 +264,23 @@
264264
265265
266def show_start_on_job_edge(ofh, from_job, to_job):266def show_start_on_job_edge(ofh, from_job, to_job):
267 show_edge(ofh, "%s:start" % mk_job_node_name(from_job),267 show_edge(ofh, "%s:job" % mk_job_node_name(to_job),
268 "%s:job" % mk_job_node_name(to_job), options.color_start_on)268 "%s:start" % mk_job_node_name(from_job), options.color_start_on)
269269
270270
271def show_start_on_event_edge(ofh, from_job, to_event):271def show_start_on_event_edge(ofh, from_job, to_event):
272 show_edge(ofh, "%s:start" % mk_job_node_name(from_job),272 show_edge(ofh, mk_event_node_name(to_event),
273 mk_event_node_name(to_event), options.color_start_on)273 "%s:start" % mk_job_node_name(from_job), options.color_start_on)
274274
275275
276def show_stop_on_job_edge(ofh, from_job, to_job):276def show_stop_on_job_edge(ofh, from_job, to_job):
277 show_edge(ofh, "%s:stop" % mk_job_node_name(from_job),277 show_edge(ofh, "%s:job" % mk_job_node_name(to_job),
278 "%s:job" % mk_job_node_name(to_job), options.color_stop_on)278 "%s:stop" % mk_job_node_name(from_job), options.color_stop_on)
279279
280280
281def show_stop_on_event_edge(ofh, from_job, to_event):281def show_stop_on_event_edge(ofh, from_job, to_event):
282 show_edge(ofh, "%s:stop" % mk_job_node_name(from_job),282 show_edge(ofh, mk_event_node_name(to_event),
283 mk_event_node_name(to_event), options.color_stop_on)283 "%s:stop" % mk_job_node_name(from_job), options.color_stop_on)
284284
285285
286def show_job_emits_edge(ofh, from_job, to_event):286def show_job_emits_edge(ofh, from_job, to_event):

Subscribers

People subscribed via source and target branches