upstart

Merge lp:~ted/upstart/flip-edges into lp:upstart

  1. flip-edges
  2. Merge into trunk
Proposed by Ted Gould
Status: Merged
Merged at revision: 1497
Proposed branch: lp:~ted/upstart/flip-edges
Merge into: lp:upstart
Diff against target: 35 lines (+8/-8)
1 file modified
scripts/initctl2dot.py (+8/-8)
To merge this branch: bzr merge lp:~ted/upstart/flip-edges
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Review via email: mp+172145@code.launchpad.net

Commit message

Flip edges to fix Graphviz rankings

Description of the change

Change the edges of the Graphviz graph so that Graphviz can figure out the rankings of the various items and generate a better diagram.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Indeed the new diagram is much better. It now displays upstart view of proactive triggering of jobs left-to-right.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/initctl2dot.py'
2--- scripts/initctl2dot.py 2013-03-22 13:50:30 +0000
3+++ scripts/initctl2dot.py 2013-06-28 20:19:25 +0000
4@@ -264,23 +264,23 @@
5
6
7 def show_start_on_job_edge(ofh, from_job, to_job):
8- show_edge(ofh, "%s:start" % mk_job_node_name(from_job),
9- "%s:job" % mk_job_node_name(to_job), options.color_start_on)
10+ show_edge(ofh, "%s:job" % mk_job_node_name(to_job),
11+ "%s:start" % mk_job_node_name(from_job), options.color_start_on)
12
13
14 def show_start_on_event_edge(ofh, from_job, to_event):
15- show_edge(ofh, "%s:start" % mk_job_node_name(from_job),
16- mk_event_node_name(to_event), options.color_start_on)
17+ show_edge(ofh, mk_event_node_name(to_event),
18+ "%s:start" % mk_job_node_name(from_job), options.color_start_on)
19
20
21 def show_stop_on_job_edge(ofh, from_job, to_job):
22- show_edge(ofh, "%s:stop" % mk_job_node_name(from_job),
23- "%s:job" % mk_job_node_name(to_job), options.color_stop_on)
24+ show_edge(ofh, "%s:job" % mk_job_node_name(to_job),
25+ "%s:stop" % mk_job_node_name(from_job), options.color_stop_on)
26
27
28 def show_stop_on_event_edge(ofh, from_job, to_event):
29- show_edge(ofh, "%s:stop" % mk_job_node_name(from_job),
30- mk_event_node_name(to_event), options.color_stop_on)
31+ show_edge(ofh, mk_event_node_name(to_event),
32+ "%s:stop" % mk_job_node_name(from_job), options.color_stop_on)
33
34
35 def show_job_emits_edge(ofh, from_job, to_event):

Subscribers

People subscribed via source and target branches