Code review comment for lp:~ted/ubuntu-system-settings/wifi-panel

On Wed, 2013-09-18 at 07:39 +0000, Alberto Mardegan wrote:

> - License: the other plugins are GPL3, not LGPL. Either is fine to me, but unless you have good reasons for having the code LGPL, it'd be easier if all the plugins use the same license.

Fixed.

> - Do not submit code commented out (MenuItemFactory.qml)

Fixed.

> - Coding style in C++ files: the "*" must have one space before it, and none after it; in classes declarations of the inheritance, put a space after the ":", but none before; last, the constructor should be indented like this:
>
> UnityMenuModelStack::UnityMenuModelStack(QObject *parent):
> QObject(parent)
> {
> }

Frankly, I'd rather keep this the same as the code that I cut-and-pasted
so that we can easily grab revisions from that code and understand the
diffs. For minor things like that I don't think divergence is a good
idea. Personally, I don't care either way on the style itself, but I'd
like to be able to diff them.