Code review comment for lp:~ted/ubuntu-system-settings/wifi-panel

Revision history for this message
Alberto Mardegan (mardy) wrote :

Wow, that's a lot of code! :-)

I didn't go through all of that, but here's just a few things I noticed:

- License: the other plugins are GPL3, not LGPL. Either is fine to me, but unless you have good reasons for having the code LGPL, it'd be easier if all the plugins use the same license.
- Do not submit code commented out (MenuItemFactory.qml)
- Coding style in C++ files: the "*" must have one space before it, and none after it; in classes declarations of the inheritance, put a space after the ":", but none before; last, the constructor should be indented like this:

UnityMenuModelStack::UnityMenuModelStack(QObject *parent):
    QObject(parent)
{
}

review: Needs Fixing

« Back to merge proposal