Merge lp:~ted/ubuntu-dev-tools/inactive-milestones into lp:~ubuntu-dev/ubuntu-dev-tools/trunk

[Ted Gould]

After using the milestone make sure to mark it as inactive. This matches the Launchpad webpage behavior.

Note: there is an odd line with the launchpad.load() function which is a work around for launchpad lib not creating the right object otherwise.

[Sebastien Bacher (seb128)]

there is a merge conflict there in the changelog

[Stefano Rivera (stefanor)]

I wouldn't worry too much about the conflicted changelog, but the fact that it depends on some Needs Fixing branches will cause merging delays.

milestone = release.milestone surely?

review: Needs Fixing

[Ted Gould (ted)]

On Mon, 2011-04-18 at 16:17 +0000, Stefano Rivera wrote:
> milestone = release.milestone surely?

One would think. That doesn't work though :-(

[Stefano Rivera (stefanor)]

I'm pretty sure that worked for me. A launchpadlib bugreport number in a comment above it would be nice.

[lp:~ted/ubuntu-dev-tools/inactive-milestones]

1070. By Ted Gould on 2011-08-18

update to update to trunk

[Benjamin Drung (bdrung)]

lp-project-upload was moved to the lptools project. Please propose a merge into that project.

review: Disapprove

Unmerged revisions

1070. By Ted Gould on 2011-08-18

update to update to trunk

1069. By Ted Gould on 2011-04-16

Updating to latest close-bugs branch

1068. By Ted Gould on 2011-04-15

Work around a bug in launchpad lib by loading the milestone using load() instead of the auto-built object.

1067. By Ted Gould on 2011-03-24

lp-project-upload: Ensure the milestone isn't still active

1066. By Ted Gould on 2011-03-24

Ensure the milestone isn't still active

1065. By Ted Gould on 2011-03-24

lp-project-upload: Close bugs on the milestone that are currently
set to "Fix Committed"

1064. By Ted Gould on 2011-03-24

Whitespace

1063. By Ted Gould on 2011-03-24

Merge in milestone updates

1062. By Ted Gould on 2011-03-24

Find the 'fix committed' bugs and mark them released

=== modified file 'debian/changelog'
--- debian/changelog	2011-08-18 15:41:41 +0000
+++ debian/changelog	2011-08-18 15:41:41 +0000
@@ -165,6 +165,7 @@
     one to use.
   * lp-project-upload: Close bugs on the milestone that are currently
     set to "Fix Committed"
+  * lp-project-upload: Ensure the milestone isn't still active
 
  -- Benjamin Drung <[e-mail]>  Tue, 19 Apr 2011 08:49:06 +0200
 
 
=== modified file 'lp-project-upload'
--- lp-project-upload	2011-08-18 15:41:41 +0000
+++ lp-project-upload	2011-08-18 15:41:41 +0000
@@ -178,6 +178,12 @@
             else:
                 mark_released(task)
 
+        # Deactivate the milestone to clean it up
+        if release.milestone.is_active:
+            local_milestone = launchpad.load(release.milestone_link)
+            local_milestone.is_active = False
+            local_milestone.lp_save()
+
         # Create a new milestone if requested
         if new_milestone is not None:
             mil = release.milestone