Code review comment for lp:~ted/ubuntu-app-launch/fdo-application-open

Revision history for this message
Loïc Minier (lool) wrote :

* the variable name "connection" is confusing in get_pid_cb() and contact_app(), could we call it connection_name?
* please add a TODO in main and in parse_uris() to use something else than space for splitting URIs; in fact it might be better to just remove support for multiple uris in this new code

So IIUC, we're first scanning by matching PID (PID that we think we've launched with upstart) then comparing the DBus bus name of the target app to match the app name; I find this a bit ugly because:
a) pids are reused, even if it's unlikely that it happens quickly and at the right time, it's bad when you can't guarantee it didn't happen
b) app names are not unique, only namespace + app name is

I'd rather we use namespace + app name as the bus name we're searching for, and connect to that; seems simple and solid. But I guess this was discussed elsewhere since we have to use the same scheme in e.g. qtubuntu?

« Back to merge proposal