On Sat, 2013-08-10 at 14:23 +0000, Charles Kerr wrote:
> The code level changes look okay.
Cool. I added an introduction similar to the one in desktop-hook to
explain it a bit better what was going on. r81.
> Optional fix: in desktop-exec.c, main()'s first dozen or so lines
> walking through g_get_user_data_dir() and g_get_systeM_data_dirs()
> look like they could be replaced by a single call to
> g_key_file_load_from_data_dirs() which does the same thing.
Looked at that, and started making the change. The one thing I didn't
like was that it would just load the first desktop file that it found.
If that one was malformed, it wouldn't fall back to the system one. So
it seems that a broken file in your user directory would haunt you
forever. So I'm going to leave it the way it is for now.
On Sat, 2013-08-10 at 14:23 +0000, Charles Kerr wrote:
> The code level changes look okay.
Cool. I added an introduction similar to the one in desktop-hook to
explain it a bit better what was going on. r81.
> Optional fix: in desktop-exec.c, main()'s first dozen or so lines data_dir( ) and g_get_systeM_ data_dirs( ) load_from_ data_dirs( ) which does the same thing.
> walking through g_get_user_
> look like they could be replaced by a single call to
> g_key_file_
Looked at that, and started making the change. The one thing I didn't
like was that it would just load the first desktop file that it found.
If that one was malformed, it wouldn't fall back to the system one. So
it seems that a broken file in your user directory would haunt you
forever. So I'm going to leave it the way it is for now.