Merge lp:~ted/ubiquity/upstart-indicators into lp:ubiquity

[Ted Gould]

If we're starting the panel, start the indicator services

When we've got a panel, start the indicator services.

[Dimitri John Ledkov (xnox)]

Is there now obsolete code in src/panel/panel.c ?
How does one specify the "profile" with indicator-services-start event? E.g. ubiquity is loading ubiquity profile at the moment.

review: Needs Information

[Dimitri John Ledkov (xnox)]

This change has to also wait for:
- 4 indicators from http://pad.lv/1241539 to be released via auto-landing machinery
- new desktop image spun up with above

As at the moment saucy & trusty load no indicators what's so ever.

[Dimitri John Ledkov (xnox)]

Traceback (most recent call last):
  File "/usr/bin/ubiquity-dm", line 677, in <module>
    ret = dm.run(*sys.argv[4:])
  File "/usr/bin/ubiquity-dm", line 484, in run
    preexec_fn=self.drop_privileges))
  File "/usr/lib/python3.3/subprocess.py", line 817, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.3/subprocess.py", line 1441, in _execute_child
    raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'init --user --startup-event indicator-services-start'

review: Needs Fixing

[Dimitri John Ledkov (xnox)]

Emitting indicator-services-start, will attempt starting:
* datetime
* power
* session
* sound
* sync

When in actual fact ubiquity wants:
* bluetooth
* keyboard
* session
* sound

At the moment, indicator-bluetooth-service and indicator-keyboard-service are running none-the-less. So why not simply launch "session" and "sound" indicators directly?

[Ted Gould (ted)]

On Sun, 2013-12-08 at 01:33 +0000, Dmitrijs Ledkovs wrote:

> Emitting indicator-services-start, will attempt starting:
> * datetime
> * power
> * session
> * sound
> * sync
>
> When in actual fact ubiquity wants:
> * bluetooth
> * keyboard
> * session
> * sound
>
> At the moment, indicator-bluetooth-service and indicator-keyboard-service are running none-the-less. So why not simply launch "session" and "sound" indicators directly?

I'm confused why you don't want the time or the battery level showing in
Ubiquity.

[Dimitri John Ledkov (xnox)]

On 8 December 2013 15:12, Ted Gould <email address hidden> wrote:
> On Sun, 2013-12-08 at 01:33 +0000, Dmitrijs Ledkovs wrote:
>
>> Emitting indicator-services-start, will attempt starting:
>> * datetime
>> * power
>> * session
>> * sound
>> * sync
>>
>> When in actual fact ubiquity wants:
>> * bluetooth
>> * keyboard
>> * session
>> * sound
>>
>> At the moment, indicator-bluetooth-service and indicator-keyboard-service are running none-the-less. So why not simply launch "session" and "sound" indicators directly?
>
>
> I'm confused why you don't want the time or the battery level showing in
> Ubiquity.
>

We do not want time, because in the installer we may not have correct
time (hardware clock is off and possibly no network to NTP correct it)
and also the installer doesn't know which timezone to show.
Therefore instead of showing wrong time, we don't show it through the
ubiquity installation. The installed system however will have NTP &
user selected timezone, therefore on first boot lightdm/unity is
expected to show time.
I'll chat with mpt, cause he was at one point working on which
indicators should be shown where & when & what they should display.

W.r.t. battery level, that's a good one. Yes, I believe we do want it.

Regards,

Dmitrijs.

[Dimitri John Ledkov (xnox)]

I think it's best to reintroduce dbus activation, and have upstart-dbus-activation patches resurrected such that, when available, dbus activated indicators are managed under upstart session init.

review: Disapprove

Unmerged revisions

6046. By Ted Gould on 2013-10-28

If we're starting the panel, start the indicator services

=== modified file 'bin/ubiquity-dm'
--- bin/ubiquity-dm	2013-10-18 22:30:43 +0000
+++ bin/ubiquity-dm	2013-10-28 19:46:28 +0000
@@ -478,6 +478,10 @@
                         ['/usr/lib/ubiquity/panel'],
                         stdin=null, stdout=logfile, stderr=logfile,
                         preexec_fn=self.drop_privileges))
+                    extras.append(subprocess.Popen(
+                        ['init --user --startup-event indicator-services-start'],
+                        stdin=null, stdout=logfile, stderr=logfile,
+                        preexec_fn=self.drop_privileges))
 
             if (osextras.find_on_path('nm-applet') and
                     "gnome-shell" not in wm_cmd):