Merge lp:~ted/libmetrics/study-version into lp:libmetrics

Proposed by Ted Gould
Status: Merged
Merged at revision: 61
Proposed branch: lp:~ted/libmetrics/study-version
Merge into: lp:libmetrics
Diff against target: 84 lines (+19/-1)
8 files modified
libmetrics/collector.c (+4/-1)
tests/studies/bad-no-administrator (+1/-0)
tests/studies/bad-no-description (+1/-0)
tests/studies/bad-no-name (+1/-0)
tests/studies/bad-no-version (+4/-0)
tests/studies/bad-version-200 (+5/-0)
tests/studies/good (+1/-0)
tests/test-collector.cc (+2/-0)
To merge this branch: bzr merge lp:~ted/libmetrics/study-version
Reviewer Review Type Date Requested Status
Metrics Pending
Review via email: mp+106044@code.launchpad.net

Description of the change

Adding a version number to the study file

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libmetrics/collector.c'
--- libmetrics/collector.c 2012-05-16 17:48:32 +0000
+++ libmetrics/collector.c 2012-05-16 18:22:18 +0000
@@ -196,7 +196,10 @@
196 if (g_key_file_has_group(keyfile, "Metrics Study") &&196 if (g_key_file_has_group(keyfile, "Metrics Study") &&
197 g_key_file_has_key(keyfile, "Metrics Study", "Name", NULL) &&197 g_key_file_has_key(keyfile, "Metrics Study", "Name", NULL) &&
198 g_key_file_has_key(keyfile, "Metrics Study", "Description", NULL) &&198 g_key_file_has_key(keyfile, "Metrics Study", "Description", NULL) &&
199 g_key_file_has_key(keyfile, "Metrics Study", "Administrator", NULL)) {199 g_key_file_has_key(keyfile, "Metrics Study", "Version", NULL) &&
200 g_key_file_has_key(keyfile, "Metrics Study", "Administrator", NULL) &&
201 g_key_file_get_int64(keyfile, "Metrics Study", "Version", NULL) == 1
202 ) {
200 self->priv->study = g_strdup(study);203 self->priv->study = g_strdup(study);
201 }204 }
202205
203206
=== modified file 'tests/studies/bad-no-administrator'
--- tests/studies/bad-no-administrator 2012-05-16 17:48:32 +0000
+++ tests/studies/bad-no-administrator 2012-05-16 18:22:18 +0000
@@ -1,3 +1,4 @@
1[Metrics Study]1[Metrics Study]
2Name=Bad Study2Name=Bad Study
3Version=1
3Description=A study that is missing an administrator4Description=A study that is missing an administrator
45
=== modified file 'tests/studies/bad-no-description'
--- tests/studies/bad-no-description 2012-05-16 17:48:32 +0000
+++ tests/studies/bad-no-description 2012-05-16 18:22:18 +0000
@@ -1,3 +1,4 @@
1[Metrics Study]1[Metrics Study]
2Name=Bad Study2Name=Bad Study
3Version=1
3Administrator=libmetrics Developers4Administrator=libmetrics Developers
45
=== modified file 'tests/studies/bad-no-name'
--- tests/studies/bad-no-name 2012-05-16 17:48:32 +0000
+++ tests/studies/bad-no-name 2012-05-16 18:22:18 +0000
@@ -1,3 +1,4 @@
1[Metrics Study]1[Metrics Study]
2Version=1
2Description=A study that is missing a name3Description=A study that is missing a name
3Administrator=libmetrics Developers4Administrator=libmetrics Developers
45
=== added file 'tests/studies/bad-no-version'
--- tests/studies/bad-no-version 1970-01-01 00:00:00 +0000
+++ tests/studies/bad-no-version 2012-05-16 18:22:18 +0000
@@ -0,0 +1,4 @@
1[Metrics Study]
2Name=Bad Study
3Description=A study that has no version specified
4Administrator=libmetrics Developers
05
=== added file 'tests/studies/bad-version-200'
--- tests/studies/bad-version-200 1970-01-01 00:00:00 +0000
+++ tests/studies/bad-version-200 2012-05-16 18:22:18 +0000
@@ -0,0 +1,5 @@
1[Metrics Study]
2Name=Bad Study
3Version=200
4Description=A study that has a version number of 200
5Administrator=libmetrics Developers
06
=== modified file 'tests/studies/good'
--- tests/studies/good 2012-05-16 17:48:32 +0000
+++ tests/studies/good 2012-05-16 18:22:18 +0000
@@ -1,4 +1,5 @@
1[Metrics Study]1[Metrics Study]
2Name=Good Study2Name=Good Study
3Version=1
3Description=A study that is good for testing4Description=A study that is good for testing
4Administrator=libmetrics Developers5Administrator=libmetrics Developers
56
=== modified file 'tests/test-collector.cc'
--- tests/test-collector.cc 2012-05-16 17:48:32 +0000
+++ tests/test-collector.cc 2012-05-16 18:22:18 +0000
@@ -70,6 +70,8 @@
7070
71TEST_F(TestCollector, bad_studies) {71TEST_F(TestCollector, bad_studies) {
72 test_bad("bad-no-administrator");72 test_bad("bad-no-administrator");
73 test_bad("bad-no-version");
74 test_bad("bad-version-200");
73 test_bad("bad-no-description");75 test_bad("bad-no-description");
74 test_bad("bad-no-name");76 test_bad("bad-no-name");
75 test_bad("bad-xml");77 test_bad("bad-xml");

Subscribers

People subscribed via source and target branches

to all changes: