Code review comment for lp:~ted/libdbusmenu/serializable-menuitem

Revision history for this message
Ted Gould (ted) wrote :

On Thu, 2011-01-27 at 09:49 +0000, Mikkel Kamstrup Erlandsen wrote:
> The function prototypes DbusmenuClientTypeHandler and
> DbusmenuClientTypeDestroyHandler needs documentation.

r215

> Can we avoid double namespacing on these two functions?:
>
> dbusmenu_gtk_serializable_menu_item_build_dbusmenu_menuitem()
> dbusmenu_gtk_serializable_menu_item_set_dbusmenu_menuitem()
>
> Becomes:
>
> dbusmenu_gtk_serializable_menu_item_build_menuitem()
> dbusmenu_gtk_serializable_menu_item_set_menuitem()

Yes, was looking for a good way to shorten these, thanks!

r214

> Can you add some section docs describing what the purpose of
> DbusmenuGtkSerializableMenuItem is, and how to use it? After
> reviewing this code I am still not entirely sure what it's
> supposed to do :-)

r216

« Back to merge proposal