Merge lp:~ted/libdbusmenu/double-underscore into lp:libdbusmenu/0.6
Proposed by
Ted Gould
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Charles Kerr | ||||
Approved revision: | 407 | ||||
Merged at revision: | 416 | ||||
Proposed branch: | lp:~ted/libdbusmenu/double-underscore | ||||
Merge into: | lp:libdbusmenu/0.6 | ||||
Diff against target: |
12 lines (+1/-1) 1 file modified
libdbusmenu-gtk/genericmenuitem.c (+1/-1) |
||||
To merge this branch: | bzr merge lp:~ted/libdbusmenu/double-underscore | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr (community) | Approve | ||
Review via email: mp+101772@code.launchpad.net |
Description of the change
Making the function static, and possibly inline.
To post a comment you must log in.
I don't think that G_INLINE_FUNC does what you're intending here.
> G_INLINE_FUNC INLINES before
>
> This macro is used to export function prototypes so they can be linked with an external version when no
> inlining is performed. The file which implements the functions should define G_IMPLEMENTS_
> including the headers which contain G_INLINE_FUNC declarations. Since inlining is very compiler-dependent
> using these macros correctly is very difficult. Their use is strongly discouraged.
>
> This macro is often mistaken for a replacement for the inline keyword; inline is already declared in a
> portable manner in the GLib headers and can be used normally.