Code review comment for lp:~ted/libdbusmenu/double-underscore

Charles Kerr (charlesk) wrote :

I don't think that G_INLINE_FUNC does what you're intending here.

> This macro is used to export function prototypes so they can be linked with an external version when no
> inlining is performed. The file which implements the functions should define G_IMPLEMENTS_INLINES before
> including the headers which contain G_INLINE_FUNC declarations. Since inlining is very compiler-dependent
> using these macros correctly is very difficult. Their use is strongly discouraged.
> This macro is often mistaken for a replacement for the inline keyword; inline is already declared in a
> portable manner in the GLib headers and can be used normally.

review: Needs Fixing

« Back to merge proposal