Code review comment for lp:~ted/indicator-sound/greeter-control

Revision history for this message
Charles Kerr (charlesk) wrote :

 * Is Recommends sufficient for accountsservice? Surely it's a Depends now...?

 * In GreeterBroadcast, RequestApplicationStart(), RequestHomeShown(), StartApplication(),
   ShowHome() appear to be unused. Is there another branch waiting to be stacked on top
   of this one? Otherwise, these unused methods/signals should be removed

 * In accounts-service-user, probably ought to Warn() if username != g_get_user_name()
   instead of returning silently... if that argument's wrong, something's gone wrong
   in MediaPlayerListGreeter

« Back to merge proposal