Code review comment for lp:~ted/indicator-session/upstart-job

On Tue, 2013-08-27 at 18:29 +0000, Sebastien Bacher wrote:

> - why do we need/want to export G_MESSAGES_DEBUG from the job? Should
> that be the default in the source if that should be the default
> behaviour?

I figured this was a good way to start, as the change may break
things :-) I think that we should look at removing it as we start to
get more stable.

> - do we win anything from the change today? (said differently: do we
> need this cycle? I'm for using upstart, but that indicator doesn't
> seem a candidate for much dynamic rules and we still have environment
> issues with upstart job atm)

The biggest driver for the change today is from QA. They want to be
able to shutdown the individual services without having them restart so
that they can replace them with mocks.

> - you restrict the session to Ubuntu, wasn't the indicator used by
> gnome-panel sessions as well?

Uhm, that's interesting. I'm not sure what the mask should be there, !=
ubuntu-touch ?