Code review comment for lp:~ted/indicator-session/upstart-job

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work, some questions:

- why do we need/want to export G_MESSAGES_DEBUG from the job? Should that be the default in the source if that should be the default behaviour?

- do we win anything from the change today? (said differently: do we need this cycle? I'm for using upstart, but that indicator doesn't seem a candidate for much dynamic rules and we still have environment issues with upstart job atm)

- you restrict the session to Ubuntu, wasn't the indicator used by gnome-panel sessions as well?

review: Needs Information

« Back to merge proposal