Merge lp:~ted/indicator-power/upstart-job into lp:indicator-power/13.10

Proposed by Ted Gould
Status: Superseded
Proposed branch: lp:~ted/indicator-power/upstart-job
Merge into: lp:indicator-power/13.10
Diff against target: 130 lines (+64/-14)
7 files modified
data/Makefile.am (+24/-11)
data/com.canonical.indicator.power (+3/-0)
data/indicator-power.conf.in (+11/-0)
data/indicator-power.desktop.in (+9/-0)
data/indicator-power.service.in (+0/-3)
debian/changelog (+16/-0)
src/ib-brightness-control.c (+1/-0)
To merge this branch: bzr merge lp:~ted/indicator-power/upstart-job
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Indicator Applet Developers Pending
Review via email: mp+182445@code.launchpad.net

This proposal has been superseded by a proposal from 2013-10-29.

Commit message

Switching DBus service to an Upstart Job.

Description of the change

Switching DBus service to an Upstart Job.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~ted/indicator-power/upstart-job updated
192. By Ted Gould

Dropping debugging for system-wide support

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~ted/indicator-power/upstart-job updated
193. By Ted Gould

Updating to trunk

194. By Ted Gould

Add in the autostart config

Unmerged revisions

194. By Ted Gould

Add in the autostart config

193. By Ted Gould

Updating to trunk

192. By Ted Gould

Dropping debugging for system-wide support

191. By Ted Gould

Switching the dvus service to an upstart job

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/Makefile.am'
--- data/Makefile.am 2013-07-04 20:14:54 +0000
+++ data/Makefile.am 2013-10-29 16:30:39 +0000
@@ -10,17 +10,30 @@
10dist_indicators_DATA = com.canonical.indicator.power10dist_indicators_DATA = com.canonical.indicator.power
1111
12#12#
13# the dbus service file13# the upstart job file
14#14#
1515
16dbus_servicesdir = $(datadir)/dbus-1/services16upstart_jobsdir = $(datadir)/upstart/sessions
17dbus_services_DATA = indicator-power.service17upstart_jobs_DATA = indicator-power.conf
18dbus_services_in = $(dbus_services_DATA:.service=.service.in)18upstart_jobs_in = $(upstart_jobs_DATA:.conf=.conf.in)
19$(dbus_services_DATA): $(dbus_services_in)19$(upstart_jobs_DATA): $(upstart_jobs_in)
20 $(AM_V_GEN) $(SED) -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@20 $(AM_V_GEN) $(SED) -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
21BUILT_SOURCES += $(dbus_services_DATA)21BUILT_SOURCES += $(upstart_jobs_DATA)
22CLEANFILES += $(dbus_services_DATA)22CLEANFILES += $(upstart_jobs_DATA)
23EXTRA_DIST += $(dbus_services_in)23EXTRA_DIST += $(upstart_jobs_in)
24
25#
26# the xdg autostart job file
27#
28
29xdg_autostartdir = /etc/xdg/autostart
30xdg_autostart_DATA = indicator-power.desktop
31xdg_autostart_in = $(xdg_autostart_DATA:.desktop=.desktop.in)
32$(xdg_autostart_DATA): $(xdg_autostart_in)
33 $(AM_V_GEN) $(SED) -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
34BUILT_SOURCES += $(xdg_autostart_DATA)
35CLEANFILES += $(xdg_autostart_DATA)
36EXTRA_DIST += $(xdg_autostart_in)
2437
25#38#
26# the gettings39# the gettings
2740
=== modified file 'data/com.canonical.indicator.power'
--- data/com.canonical.indicator.power 2013-07-24 05:10:17 +0000
+++ data/com.canonical.indicator.power 2013-10-29 16:30:39 +0000
@@ -11,3 +11,6 @@
1111
12[desktop_greeter]12[desktop_greeter]
13ObjectPath=/com/canonical/indicator/power/desktop_greeter13ObjectPath=/com/canonical/indicator/power/desktop_greeter
14
15[phone_greeter]
16ObjectPath=/com/canonical/indicator/power/desktop_greeter
1417
=== added file 'data/indicator-power.conf.in'
--- data/indicator-power.conf.in 1970-01-01 00:00:00 +0000
+++ data/indicator-power.conf.in 2013-10-29 16:30:39 +0000
@@ -0,0 +1,11 @@
1description "Indicator Power Backend"
2
3# Want to move to indicator-services-[start|end], but that's not all
4# there yet. Use the signals that exist today for now.
5
6start on indicators-loaded or indicator-services-start
7stop on desktop-end or indicator-services-end
8
9respawn
10
11exec @pkglibexecdir@/indicator-power-service
012
=== added file 'data/indicator-power.desktop.in'
--- data/indicator-power.desktop.in 1970-01-01 00:00:00 +0000
+++ data/indicator-power.desktop.in 2013-10-29 16:30:39 +0000
@@ -0,0 +1,9 @@
1[Desktop Entry]
2Type=Application
3Name=Indicator Power
4Exec=@pkglibexecdir@/indicator-power-service
5NotShowIn=Unity;
6NoDisplay=true
7StartupNotify=false
8Terminal=false
9
010
=== removed file 'data/indicator-power.service.in'
--- data/indicator-power.service.in 2013-07-04 20:14:54 +0000
+++ data/indicator-power.service.in 1970-01-01 00:00:00 +0000
@@ -1,3 +0,0 @@
1[D-BUS Service]
2Name=com.canonical.indicator.power
3Exec=@pkglibexecdir@/indicator-power-service
40
=== modified file 'debian/changelog'
--- debian/changelog 2013-10-08 02:34:02 +0000
+++ debian/changelog 2013-10-29 16:30:39 +0000
@@ -1,3 +1,19 @@
1indicator-power (12.10.6+14.04.20131029.1-0ubuntu1) trusty; urgency=low
2
3 [ Sebastien Bacher ]
4 * Don't leak the g_file_get_contents value, reported by valgrind .
5
6 [ Marcus Tomlinson ]
7 * Added torch icons to either end of brightness slider. (LP: #1227250)
8
9 [ Ted Gould ]
10 * Adding a phone_greeter profile.
11
12 [ Ubuntu daily release ]
13 * Automatic snapshot from revision 210
14
15 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Tue, 29 Oct 2013 10:31:03 +0000
16
1indicator-power (12.10.6+13.10.20131008-0ubuntu1) saucy; urgency=low17indicator-power (12.10.6+13.10.20131008-0ubuntu1) saucy; urgency=low
218
3 [ Ted Gould ]19 [ Ted Gould ]
420
=== modified file 'src/ib-brightness-control.c'
--- src/ib-brightness-control.c 2013-10-01 18:50:10 +0000
+++ src/ib-brightness-control.c 2013-10-29 16:30:39 +0000
@@ -126,6 +126,7 @@
126 g_error_free (error);126 g_error_free (error);
127 } else {127 } else {
128 value = atoi (svalue);128 value = atoi (svalue);
129 g_free (svalue);
129 }130 }
130131
131 g_free (filename);132 g_free (filename);

Subscribers

People subscribed via source and target branches