Merge lp:~ted/indicator-network/drop-airplane into lp:indicator-network/13.10

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 288
Merged at revision: 286
Proposed branch: lp:~ted/indicator-network/drop-airplane
Merge into: lp:indicator-network/13.10
Diff against target: 33 lines (+8/-4)
2 files modified
network/device-wifi.vala (+1/-1)
network/network-menu.vala (+7/-3)
To merge this branch: bzr merge lp:~ted/indicator-network/drop-airplane
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+188423@code.launchpad.net

Commit message

Drop Airplane Mode for Phone 1.0

Description of the change

Drops the airplane mode toggle switch at the top of the indicator as this won't be supported in Phone 1.0

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'network/device-wifi.vala'
--- network/device-wifi.vala 2013-09-16 04:07:59 +0000
+++ network/device-wifi.vala 2013-09-30 18:54:10 +0000
@@ -524,7 +524,7 @@
524 muxer: muxer524 muxer: muxer
525 );525 );
526526
527 wifimenu = new WifiMenu(client, device, this._menu, actions, "indicator." + this.namespace + ".", false);527 wifimenu = new WifiMenu(client, device, this._menu, actions, "indicator." + this.namespace + ".", show_settings);
528 wifiactionmanager = new WifiActionManager(actions, client, device);528 wifiactionmanager = new WifiActionManager(actions, client, device);
529 }529 }
530530
531531
=== modified file 'network/network-menu.vala'
--- network/network-menu.vala 2013-09-13 21:33:47 +0000
+++ network/network-menu.vala 2013-09-30 18:54:10 +0000
@@ -211,9 +211,13 @@
211211
212 /* Put an airplane mode setting at the top of the desktop and phone212 /* Put an airplane mode setting at the top of the desktop and phone
213 menus */213 menus */
214 var airplane = new Network.Settings.Airplane(muxer);214 /* Airplane mode is disabled for Phone 1.0 as there's no backend.
215 desktop.set_pre_settings(airplane);215 commenting out to be reenabled after 1.0 ships */
216 phone.set_pre_settings(airplane);216 if (false) {
217 var airplane = new Network.Settings.Airplane(muxer);
218 desktop.set_pre_settings(airplane);
219 phone.set_pre_settings(airplane);
220 }
217221
218 /* Add some items at the end of the settings menu */222 /* Add some items at the end of the settings menu */
219 var wifisettings = new Network.Settings.Wifi(muxer);223 var wifisettings = new Network.Settings.Wifi(muxer);

Subscribers

People subscribed via source and target branches