Merge lp:~ted/indicator-network/drop-airplane into lp:indicator-network/13.10

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 288
Merged at revision: 286
Proposed branch: lp:~ted/indicator-network/drop-airplane
Merge into: lp:indicator-network/13.10
Diff against target: 33 lines (+8/-4)
2 files modified
network/device-wifi.vala (+1/-1)
network/network-menu.vala (+7/-3)
To merge this branch: bzr merge lp:~ted/indicator-network/drop-airplane
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+188423@code.launchpad.net

Commit message

Drop Airplane Mode for Phone 1.0

Description of the change

Drops the airplane mode toggle switch at the top of the indicator as this won't be supported in Phone 1.0

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'network/device-wifi.vala'
2--- network/device-wifi.vala 2013-09-16 04:07:59 +0000
3+++ network/device-wifi.vala 2013-09-30 18:54:10 +0000
4@@ -524,7 +524,7 @@
5 muxer: muxer
6 );
7
8- wifimenu = new WifiMenu(client, device, this._menu, actions, "indicator." + this.namespace + ".", false);
9+ wifimenu = new WifiMenu(client, device, this._menu, actions, "indicator." + this.namespace + ".", show_settings);
10 wifiactionmanager = new WifiActionManager(actions, client, device);
11 }
12
13
14=== modified file 'network/network-menu.vala'
15--- network/network-menu.vala 2013-09-13 21:33:47 +0000
16+++ network/network-menu.vala 2013-09-30 18:54:10 +0000
17@@ -211,9 +211,13 @@
18
19 /* Put an airplane mode setting at the top of the desktop and phone
20 menus */
21- var airplane = new Network.Settings.Airplane(muxer);
22- desktop.set_pre_settings(airplane);
23- phone.set_pre_settings(airplane);
24+ /* Airplane mode is disabled for Phone 1.0 as there's no backend.
25+ commenting out to be reenabled after 1.0 ships */
26+ if (false) {
27+ var airplane = new Network.Settings.Airplane(muxer);
28+ desktop.set_pre_settings(airplane);
29+ phone.set_pre_settings(airplane);
30+ }
31
32 /* Add some items at the end of the settings menu */
33 var wifisettings = new Network.Settings.Wifi(muxer);

Subscribers

People subscribed via source and target branches