Code review comment for lp:~ted/indicator-network/blank-items

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, that seems to fix the issue, it just hit a segfaults though:

#0 util_wrapper_is_empty_ssid (bytes=0x0)
    at /home/seb128/boulot/package/download/ted/build-area/indicator-network-0.5.1+13.10.20131005/network/util-wrapper.c:26
#1 0x08053bbb in network_device_wifi_menu_insert_ap_item (
    self=self@entry=0x8bbe370, ap=ap@entry=0x8bd72c8)
    at /home/seb128/boulot/package/download/ted/build-area/indicator-network-0.5.1+13.10.20131005/obj-i686-linux-gnu/network/device-wifi.c:774
#2 0x080542b7 in network_device_wifi_menu_access_point_added_cb (
    self=0x8bbe370, device=<optimized out>, user_data=<optimized out>)
    at /home/seb128/boulot/package/download/ted/build-area/indicator-network-0.5.1+13.10.20131005/obj-i686-linux-gnu/network/device-wifi.c:599
#3 0xb75c558e in g_cclosure_marshal_VOID__OBJECT (closure=0x8c0bd58,
    return_value=0x0, n_param_values=2, param_values=0xbf887d50,
    invocation_hint=0xbf887cfc, marshal_data=0x0)
    at /build/buildd/glib2.0-2.38.0/./gobject/gmarshal.c:1272
#4 0xb75c28ae in g_closure_invoke (closure=0x8c0bd58,
    return_value=return_value@entry=0x0, n_param_values=2,
    param_values=param_values@entry=0xbf887d50,
    invocation_hint=invocation_hint@entry=0xbf887cfc)
    at /build/buildd/glib2.0-2.38.0/./gobject/gclosure.c:777

review: Needs Fixing

« Back to merge proposal