Merge lp:~ted/indicator-messages/merge-policy into lp:indicator-messages/14.04

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 402
Merged at revision: 402
Proposed branch: lp:~ted/indicator-messages/merge-policy
Merge into: lp:indicator-messages/14.04
Diff against target: 53 lines (+43/-0)
2 files modified
MERGE-REVIEW (+19/-0)
tests/manual (+24/-0)
To merge this branch: bzr merge lp:~ted/indicator-messages/merge-policy
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Charles Kerr (community) Approve
Review via email: mp+204340@code.launchpad.net

Commit message

Adding acceptance tests and merge review policies

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'MERGE-REVIEW'
--- MERGE-REVIEW 1970-01-01 00:00:00 +0000
+++ MERGE-REVIEW 2014-01-31 20:22:46 +0000
@@ -0,0 +1,19 @@
1
2This documents the expections that the project has on what both submitters
3and reviewers should ensure that they've done for a merge into the project.
4
5== Submitter Responsibilities ==
6
7 * Ensure the project compiles and the test suite executes without error
8 * Ensure that non-obvious code has comments explaining it
9 * If the change works on specific profiles, please include those in the merge description.
10
11== Reviewer Responsibilities ==
12
13 * Did the Jenkins build compile? Pass? Run unit tests successfully?
14 * Are there appropriate tests to cover any new functionality?
15 * If the description says this effects the phone profile:
16 * Run tests indicator-messages/unity8*
17 * If the description says this effects the desktop profile:
18 * Run tests indicator-messages/unity7*
19
020
=== added directory 'tests'
=== added file 'tests/manual'
--- tests/manual 1970-01-01 00:00:00 +0000
+++ tests/manual 2014-01-31 20:22:46 +0000
@@ -0,0 +1,24 @@
1
2Test-case indicator-messages/unity7-items-check
3<dl>
4 <dt>Log in to a Unity 7 user session</dt>
5 <dt>Go to the panel and click on the Messages indicator</dt>
6 <dd>Ensure there are items in the menu</dd>
7</dl>
8
9Test-case indicator-messages/unity7-greeter-items-check
10<dl>
11 <dt>Start a system and wait for the greeter or logout of the current user session</dt>
12 <dt>Go to the panel and click on the Messages indicator</dt>
13 <dd>Ensure there are items in the menu</dd>
14</dl>
15
16Test-case indicator-messages/unity8-items-check
17<dl>
18 <dt>Login to a user session running Unity 8</dt>
19 <dt>Pull down the top panel until it sticks open</dt>
20 <dt>Navigate through the tabs until "Incoming" is shown</dt>
21 <dd>Incoming is at the top of the menu</dd>
22 <dd>The menu is populated with items</dd>
23</dl>
24

Subscribers

People subscribed via source and target branches