Merge lp:~ted/indicator-datetime/systemd-unit into lp:indicator-datetime

Proposed by Ted Gould
Status: Merged
Approved by: Martin Pitt
Approved revision: 460
Merged at revision: 463
Proposed branch: lp:~ted/indicator-datetime/systemd-unit
Merge into: lp:indicator-datetime
Diff against target: 82 lines (+44/-0)
4 files modified
data/CMakeLists.txt (+32/-0)
data/indicator-datetime.override (+1/-0)
data/indicator-datetime.service.in (+8/-0)
debian/control (+3/-0)
To merge this branch: bzr merge lp:~ted/indicator-datetime/systemd-unit
Reviewer Review Type Date Requested Status
Martin Pitt Approve
unity-api-1-bot continuous-integration Approve
PS Jenkins bot continuous-integration Pending
Indicator Applet Developers Pending
Review via email: mp+300420@code.launchpad.net

Commit message

Adding a systemd user unit

Description of the change

New fun snappy stuff

To post a comment you must log in.
458. By Ted Gould

Vivid is amazing

459. By Ted Gould

Adding a restart rule

460. By Ted Gould

Merging trunk and resolving conflicts

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:460
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-datetime-ci/2/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/605
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/611
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/434
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/434/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/434
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/434/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/434
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/434/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/434
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/434/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/434
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/434/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/434
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/434/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/434
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/434/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/434
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/434/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/434
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/434/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-datetime-ci/2/rebuild

review: Approve (continuous-integration)
Revision history for this message
Martin Pitt (pitti) wrote :

This ends up as ExecStart=/indicator-datetime-service, so the unit fails to start.

review: Needs Fixing
Revision history for this message
Martin Pitt (pitti) wrote :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/CMakeLists.txt'
--- data/CMakeLists.txt 2016-05-14 02:07:10 +0000
+++ data/CMakeLists.txt 2016-07-22 19:03:43 +0000
@@ -17,6 +17,38 @@
17add_schema (${SCHEMA_FILE})17add_schema (${SCHEMA_FILE})
1818
19##19##
20## Systemd Unit File
21##
22
23# where to install
24# Uncomment when we drop Vivid
25# pkg_get_variable(SYSTEMD_USER_DIR systemd systemduserunitdir)
26set (SYSTEMD_USER_DIR "/usr/lib/systemd/user")
27message (STATUS "${SYSTEMD_USER_DIR} is the systemd user unit file install dir")
28
29set (SYSTEMD_USER_NAME "${CMAKE_PROJECT_NAME}.service")
30set (SYSTEMD_USER_FILE "${CMAKE_CURRENT_BINARY_DIR}/${SYSTEMD_USER_NAME}")
31set (SYSTEMD_USER_FILE_IN "${CMAKE_CURRENT_SOURCE_DIR}/${SYSTEMD_USER_NAME}.in")
32
33# build it
34set (pkglibexecdir "${CMAKE_INSTALL_FULL_PKGLIBEXECDIR}")
35configure_file ("${SYSTEMD_USER_FILE_IN}" "${SYSTEMD_USER_FILE}")
36
37# install it
38install (FILES "${SYSTEMD_USER_FILE}"
39 DESTINATION "${SYSTEMD_USER_DIR}")
40
41##
42## Upstart systemd override Job File
43##
44
45set (UPSTART_SYSTEMD_OVERRIDE_DIR "${CMAKE_INSTALL_FULL_DATADIR}/upstart/systemd-session/upstart")
46message (STATUS "${UPSTART_SYSTEMD_OVERRIDE_DIR} is the Upstart override Job File for systemd dir")
47
48install (FILES "${CMAKE_CURRENT_SOURCE_DIR}/${CMAKE_PROJECT_NAME}.override"
49 DESTINATION "${UPSTART_SYSTEMD_OVERRIDE_DIR}")
50
51##
20## Upstart Job File52## Upstart Job File
21##53##
2254
2355
=== added file 'data/indicator-datetime.override'
--- data/indicator-datetime.override 1970-01-01 00:00:00 +0000
+++ data/indicator-datetime.override 2016-07-22 19:03:43 +0000
@@ -0,0 +1,1 @@
1manual
02
=== added file 'data/indicator-datetime.service.in'
--- data/indicator-datetime.service.in 1970-01-01 00:00:00 +0000
+++ data/indicator-datetime.service.in 2016-07-22 19:03:43 +0000
@@ -0,0 +1,8 @@
1[Unit]
2Description=Indicator Date & Time Backend
3PartOf=graphical-session.target
4After=indicators-pre.target
5
6[Service]
7ExecStart=@pkglibexec@/indicator-datetime-service
8Restart=on-failure
09
=== modified file 'debian/control'
--- debian/control 2016-07-01 19:46:40 +0000
+++ debian/control 2016-07-22 19:03:43 +0000
@@ -35,6 +35,8 @@
35 libmessaging-menu-dev,35 libmessaging-menu-dev,
36 uuid-dev,36 uuid-dev,
37 libubuntu-app-launch2-dev (>= 0.9),37 libubuntu-app-launch2-dev (>= 0.9),
38# to locate the place to put systemd files
39 systemd,
38Standards-Version: 3.9.340Standards-Version: 3.9.3
39Homepage: https://launchpad.net/indicator-datetime41Homepage: https://launchpad.net/indicator-datetime
40# If you aren't a member of ~indicator-applet-developers but need to upload42# If you aren't a member of ~indicator-applet-developers but need to upload
@@ -48,6 +50,7 @@
48Depends: ${shlibs:Depends}, 50Depends: ${shlibs:Depends},
49 ${misc:Depends},51 ${misc:Depends},
50 gsettings-ubuntu-schemas (>= 0.0.7),52 gsettings-ubuntu-schemas (>= 0.0.7),
53 indicator-common,
51 systemd | systemd-shim,54 systemd | systemd-shim,
52Recommends: indicator-applet | indicator-renderer,55Recommends: indicator-applet | indicator-renderer,
53 evolution-data-server,56 evolution-data-server,

Subscribers

People subscribed via source and target branches