Merge lp:~ted/indicator-datetime/bug714763 into lp:indicator-datetime/0.3

Proposed by Ted Gould
Status: Merged
Merged at revision: 41
Proposed branch: lp:~ted/indicator-datetime/bug714763
Merge into: lp:indicator-datetime/0.3
Diff against target: 34 lines (+8/-2)
2 files modified
configure.ac (+2/-2)
src/datetime-service.c (+6/-0)
To merge this branch: bzr merge lp:~ted/indicator-datetime/bug714763
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+48837@code.launchpad.net

Description of the change

Handle the case where we can't get a client. Deserves a messy message, but we can continue.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

If this happens because geoclue-master crashes then I think it deserves a more sensible error message. It's not a programming error but a runtime error.

lp:~ted/indicator-datetime/bug714763 updated
40. By Ted Gould

Changing warning.

Revision history for this message
Ted Gould (ted) wrote :

On Tue, 2011-02-08 at 09:49 +0000, Mikkel Kamstrup Erlandsen wrote:
> If this happens because geoclue-master crashes then I think it deserves
> a more sensible error message. It's not a programming error but a
> runtime error.

I think it's a programming error in GeoClue ;)

Yeah, I put a more user friendly message in so that people could see
what the impact is.

lp:~ted/indicator-datetime/bug714763 updated
41. By Ted Gould

Made translatable as it's a user focused message.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2011-01-27 22:34:24 +0000
+++ configure.ac 2011-02-08 19:49:13 +0000
@@ -1,11 +1,11 @@
11
2AC_INIT(indicator-datetime, 0.1.91, ted@canonical.com)2AC_INIT(indicator-datetime, 0.1.92, ted@canonical.com)
3AC_COPYRIGHT([Copyright 2009,2010 Canonical])3AC_COPYRIGHT([Copyright 2009,2010 Canonical])
44
5AC_PREREQ(2.53)5AC_PREREQ(2.53)
66
7AM_CONFIG_HEADER(config.h)7AM_CONFIG_HEADER(config.h)
8AM_INIT_AUTOMAKE(indicator-datetime, 0.1.91)8AM_INIT_AUTOMAKE(indicator-datetime, 0.1.92)
99
10AM_MAINTAINER_MODE10AM_MAINTAINER_MODE
1111
1212
=== modified file 'src/datetime-service.c'
--- src/datetime-service.c 2011-02-01 15:52:10 +0000
+++ src/datetime-service.c 2011-02-08 19:49:13 +0000
@@ -512,6 +512,12 @@
512 g_debug("Created Geoclue client at: %s", path);512 g_debug("Created Geoclue client at: %s", path);
513513
514 geo_master = client;514 geo_master = client;
515
516 if (geo_master != NULL) {
517 g_warning(_("Unable to get a GeoClue client! Geolocation based timezone support will not be available."));
518 return;
519 }
520
515 g_object_ref(G_OBJECT(geo_master));521 g_object_ref(G_OBJECT(geo_master));
516522
517 /* New client, make sure we don't have an address hanging on */523 /* New client, make sure we don't have an address hanging on */

Subscribers

People subscribed via source and target branches

to all changes: