Merge lp:~ted/indicator-datetime/bug714763 into lp:indicator-datetime/0.3

Proposed by Ted Gould
Status: Merged
Merged at revision: 41
Proposed branch: lp:~ted/indicator-datetime/bug714763
Merge into: lp:indicator-datetime/0.3
Diff against target: 34 lines (+8/-2)
2 files modified
configure.ac (+2/-2)
src/datetime-service.c (+6/-0)
To merge this branch: bzr merge lp:~ted/indicator-datetime/bug714763
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+48837@code.launchpad.net

Description of the change

Handle the case where we can't get a client. Deserves a messy message, but we can continue.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

If this happens because geoclue-master crashes then I think it deserves a more sensible error message. It's not a programming error but a runtime error.

lp:~ted/indicator-datetime/bug714763 updated
40. By Ted Gould

Changing warning.

Revision history for this message
Ted Gould (ted) wrote :

On Tue, 2011-02-08 at 09:49 +0000, Mikkel Kamstrup Erlandsen wrote:
> If this happens because geoclue-master crashes then I think it deserves
> a more sensible error message. It's not a programming error but a
> runtime error.

I think it's a programming error in GeoClue ;)

Yeah, I put a more user friendly message in so that people could see
what the impact is.

lp:~ted/indicator-datetime/bug714763 updated
41. By Ted Gould

Made translatable as it's a user focused message.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2011-01-27 22:34:24 +0000
3+++ configure.ac 2011-02-08 19:49:13 +0000
4@@ -1,11 +1,11 @@
5
6-AC_INIT(indicator-datetime, 0.1.91, ted@canonical.com)
7+AC_INIT(indicator-datetime, 0.1.92, ted@canonical.com)
8 AC_COPYRIGHT([Copyright 2009,2010 Canonical])
9
10 AC_PREREQ(2.53)
11
12 AM_CONFIG_HEADER(config.h)
13-AM_INIT_AUTOMAKE(indicator-datetime, 0.1.91)
14+AM_INIT_AUTOMAKE(indicator-datetime, 0.1.92)
15
16 AM_MAINTAINER_MODE
17
18
19=== modified file 'src/datetime-service.c'
20--- src/datetime-service.c 2011-02-01 15:52:10 +0000
21+++ src/datetime-service.c 2011-02-08 19:49:13 +0000
22@@ -512,6 +512,12 @@
23 g_debug("Created Geoclue client at: %s", path);
24
25 geo_master = client;
26+
27+ if (geo_master != NULL) {
28+ g_warning(_("Unable to get a GeoClue client! Geolocation based timezone support will not be available."));
29+ return;
30+ }
31+
32 g_object_ref(G_OBJECT(geo_master));
33
34 /* New client, make sure we don't have an address hanging on */

Subscribers

People subscribed via source and target branches

to all changes: