Code review comment for lp:~ted/indicator-appmenu/transient-windows
Revision history for this message
| Ted Gould (ted) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On Wed, 2010-06-16 at 14:07 +0000, David Barth wrote:
> I don't like that the 'while' may loop endlessly if there is an issue with
> the stack of parent and transient windows, especially for unsupported
> applications which will have no menus.
I'm not sure what you want to do here. Some sort of max number of
parented windows? What would that max be?
> I would have expected the transient window to be the focused one, and the
> code to look for the /parent/ menu (ie bamf_get_parent?).
>
> If bamf already takes care of mapping app windows and their transient
> windows, why is a traversal of the stack required?
My understanding is that you can be transient for a transient window in
theory. So we should be able to have about on top of the GIMP toolbox
which is on top of the GIMP image window.