Code review comment for lp:~ted/indicator-appmenu/transient-windows

Revision history for this message
David Barth (dbarth) wrote :

I don't like that the 'while' may loop endlessly if there is an issue with the stack of parent and transient windows, especially for unsupported applications which will have no menus.
I would have expected the transient window to be the focused one, and the code to look for the /parent/ menu (ie bamf_get_parent?).

If bamf already takes care of mapping app windows and their transient windows, why is a traversal of the stack required?

review: Needs Information

« Back to merge proposal