Code review comment for lp:~ted/indicator-appmenu/lp921288

Revision history for this message
Ted Gould (ted) wrote :

On Thu, 2012-02-09 at 06:54 +0000, Lars Uebernickel wrote:
> src/hud-dbus.c: g_error("Unable to parse HUD interface: %s", error->message);
> src/hud-dbus.c: g_error("Unable to find interface '" DBUS_IFACE "'");

I actually think these should be fatal. Considering the interface is
compiled in at built time... they *really* shouldn't fail. I'd like to
have the test suite fail in those cases.

> src/hud-dump-application.c: g_error("Usage: %s <desktop file path> [gettext domain]\n", argc[0]);

Yup, should print on STDERR not be an error. r157

« Back to merge proposal