Code review comment for lp:~ted/indicator-appmenu/lp921288

Revision history for this message
Lars Karlitski (larsu) wrote :

There are more g_error() calls in there which shouldn't be fatal:

$ grep 'g_error\>' -r src/*
src/hud-dbus.c: g_error("Unable to parse HUD interface: %s", error->message);
src/hud-dbus.c: g_error("Unable to find interface '" DBUS_IFACE "'");
src/hud-dump-application.c: g_error("Usage: %s <desktop file path> [gettext domain]\n", argc[0]);

I think we should also replace those before merging.

review: Needs Fixing

« Back to merge proposal