Merge lp:~ted/indicator-appmenu/dbusmenu-collector-rename into lp:indicator-appmenu/0.4

Proposed by Ted Gould
Status: Merged
Approved by: Mikkel Kamstrup Erlandsen
Approved revision: 183
Merged at revision: 140
Proposed branch: lp:~ted/indicator-appmenu/dbusmenu-collector-rename
Merge into: lp:indicator-appmenu/0.4
Prerequisite: lp:~ted/indicator-appmenu/hud
Diff against target: 644 lines (+119/-118)
6 files modified
.bzrignore (+2/-1)
po/POTFILES.in (+1/-1)
src/Makefile.am (+2/-2)
src/hud-search.c (+30/-30)
src/menuitem-collector.c (+50/-50)
src/menuitem-collector.h (+34/-34)
To merge this branch: bzr merge lp:~ted/indicator-appmenu/dbusmenu-collector-rename
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+90284@code.launchpad.net

Description of the change

Rename the dbusmenu-collector to menuitem-collector to avoid a potential namespace collision.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Looks good. And the diffstat can be used as a checksum to validate it #added==#removed+1. And the extra added line is in .bzrignore. So all checks up :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.bzrignore'
--- .bzrignore 2012-01-26 16:51:25 +0000
+++ .bzrignore 2012-01-26 16:51:25 +0000
@@ -125,7 +125,7 @@
125src/hud_cli-hud-cli.gcno125src/hud_cli-hud-cli.gcno
126src/hud_dump_application-dump-app-info.gcno126src/hud_dump_application-dump-app-info.gcno
127src/hud_dump_application-hud-dump-application.gcno127src/hud_dump_application-hud-dump-application.gcno
128src/hud_service-dbusmenu-collector.gcno128src/hud_service-menuitem-collector.gcno
129src/hud_service-distance.gcno129src/hud_service-distance.gcno
130src/hud_service-dump-app-info.gcno130src/hud_service-dump-app-info.gcno
131src/hud_service-hud-dbus.gcno131src/hud_service-hud-dbus.gcno
@@ -168,3 +168,4 @@
168tests/test_usage_db_simple-test-usage-db-simple.gcno168tests/test_usage_db_simple-test-usage-db-simple.gcno
169tests/test_usage_db_testapp-test-usage-db-testapp.gcda169tests/test_usage_db_testapp-test-usage-db-testapp.gcda
170tests/test_usage_db_testapp-test-usage-db-testapp.gcno170tests/test_usage_db_testapp-test-usage-db-testapp.gcno
171po/indicator-appmenu.pot
171172
=== modified file 'po/POTFILES.in'
--- po/POTFILES.in 2012-01-26 16:51:25 +0000
+++ po/POTFILES.in 2012-01-26 16:51:25 +0000
@@ -4,7 +4,7 @@
4src/hud-service.c4src/hud-service.c
5src/indicator-tracker.c5src/indicator-tracker.c
6src/hud-dbus.c6src/hud-dbus.c
7src/dbusmenu-collector.c7src/menuitem-collector.c
8src/usage-tracker.c8src/usage-tracker.c
9src/hud.interface.c9src/hud.interface.c
10src/hud-search.c10src/hud-search.c
1111
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2012-01-26 16:51:25 +0000
+++ src/Makefile.am 2012-01-26 16:51:25 +0000
@@ -81,8 +81,8 @@
81####################81####################
8282
83hud_service_SOURCES = \83hud_service_SOURCES = \
84 dbusmenu-collector.h \84 menuitem-collector.h \
85 dbusmenu-collector.c \85 menuitem-collector.c \
86 distance.h \86 distance.h \
87 distance.c \87 distance.c \
88 dump-app-info.h \88 dump-app-info.h \
8989
=== modified file 'src/hud-search.c'
--- src/hud-search.c 2012-01-26 16:51:25 +0000
+++ src/hud-search.c 2012-01-26 16:51:25 +0000
@@ -29,7 +29,7 @@
29#include <gio/gdesktopappinfo.h>29#include <gio/gdesktopappinfo.h>
3030
31#include "hud-search.h"31#include "hud-search.h"
32#include "dbusmenu-collector.h"32#include "menuitem-collector.h"
33#include "indicator-tracker.h"33#include "indicator-tracker.h"
34#include "usage-tracker.h"34#include "usage-tracker.h"
35#include "utils.h"35#include "utils.h"
@@ -41,7 +41,7 @@
41 guint32 active_xid;41 guint32 active_xid;
42 BamfApplication * active_app;42 BamfApplication * active_app;
4343
44 DbusmenuCollector * collector;44 MenuitemCollector * collector;
45 UsageTracker * usage;45 UsageTracker * usage;
4646
47 GDBusProxy * appmenu;47 GDBusProxy * appmenu;
@@ -111,7 +111,7 @@
111 }111 }
112112
113 /* DBusMenu */113 /* DBusMenu */
114 self->priv->collector = dbusmenu_collector_new();114 self->priv->collector = menuitem_collector_new();
115115
116 /* Usage Tracker */116 /* Usage Tracker */
117 self->priv->usage = usage_tracker_new();117 self->priv->usage = usage_tracker_new();
@@ -199,7 +199,7 @@
199199
200typedef struct _usage_wrapper_t usage_wrapper_t;200typedef struct _usage_wrapper_t usage_wrapper_t;
201struct _usage_wrapper_t {201struct _usage_wrapper_t {
202 DbusmenuCollectorFound * found;202 MenuitemCollectorFound * found;
203 guint count;203 guint count;
204 gfloat percent_usage;204 gfloat percent_usage;
205 gfloat percent_distance;205 gfloat percent_distance;
@@ -226,7 +226,7 @@
226 usage_wrapper_t * wa = (usage_wrapper_t *)a;226 usage_wrapper_t * wa = (usage_wrapper_t *)a;
227 usage_wrapper_t * wb = (usage_wrapper_t *)b;227 usage_wrapper_t * wb = (usage_wrapper_t *)b;
228228
229 return dbusmenu_collector_found_get_distance(wa->found) - dbusmenu_collector_found_get_distance(wb->found);229 return menuitem_collector_found_get_distance(wa->found) - menuitem_collector_found_get_distance(wb->found);
230}230}
231231
232/* Take the found list and put it into the usage array so that232/* Take the found list and put it into the usage array so that
@@ -241,10 +241,10 @@
241241
242 while (found != NULL) {242 while (found != NULL) {
243 usage_wrapper_t usage;243 usage_wrapper_t usage;
244 usage.found = (DbusmenuCollectorFound *)found->data;244 usage.found = (MenuitemCollectorFound *)found->data;
245 usage.count = 0;245 usage.count = 0;
246246
247 if (dbusmenu_collector_found_get_distance(usage.found) > max_distance) {247 if (menuitem_collector_found_get_distance(usage.found) > max_distance) {
248 continue;248 continue;
249 }249 }
250250
@@ -308,7 +308,7 @@
308 get_current_window_address(search, &address, &path);308 get_current_window_address(search, &address, &path);
309309
310 if (address != NULL && path != NULL) {310 if (address != NULL && path != NULL) {
311 found_list = dbusmenu_collector_search(search->priv->collector, address, path, NULL, searchstr);311 found_list = menuitem_collector_search(search->priv->collector, address, path, NULL, searchstr);
312 }312 }
313313
314 g_free(address);314 g_free(address);
@@ -325,13 +325,13 @@
325 gchar * icon = desktop_to_icon(desktop_file);325 gchar * icon = desktop_to_icon(desktop_file);
326326
327 while (founditem != NULL) {327 while (founditem != NULL) {
328 DbusmenuCollectorFound * found = (DbusmenuCollectorFound *)founditem->data;328 MenuitemCollectorFound * found = (MenuitemCollectorFound *)founditem->data;
329329
330 /* Indicator */330 /* Indicator */
331 dbusmenu_collector_found_set_indicator(found, desktop_file);331 menuitem_collector_found_set_indicator(found, desktop_file);
332332
333 /* Icon */333 /* Icon */
334 dbusmenu_collector_found_set_app_icon(found, icon);334 menuitem_collector_found_set_app_icon(found, icon);
335335
336 founditem = g_list_next(founditem);336 founditem = g_list_next(founditem);
337 }337 }
@@ -364,23 +364,23 @@
364 IndicatorTrackerIndicator * indicator = (IndicatorTrackerIndicator *)lindicator->data;364 IndicatorTrackerIndicator * indicator = (IndicatorTrackerIndicator *)lindicator->data;
365365
366 /* Search the menu items of the indicator */366 /* Search the menu items of the indicator */
367 GList * found_list = dbusmenu_collector_search(search->priv->collector, indicator->dbus_name, indicator->dbus_object, indicator->prefix, searchstr);367 GList * found_list = menuitem_collector_search(search->priv->collector, indicator->dbus_name, indicator->dbus_object, indicator->prefix, searchstr);
368368
369 /* Increase distance */369 /* Increase distance */
370 GList * founditem = found_list;370 GList * founditem = found_list;
371 while (founditem != NULL) {371 while (founditem != NULL) {
372 DbusmenuCollectorFound * found = (DbusmenuCollectorFound *)founditem->data;372 MenuitemCollectorFound * found = (MenuitemCollectorFound *)founditem->data;
373373
374 /* Distance */374 /* Distance */
375 guint distance = dbusmenu_collector_found_get_distance(found);375 guint distance = menuitem_collector_found_get_distance(found);
376 distance = distance + ((distance * indicator_penalty) / 100);376 distance = distance + ((distance * indicator_penalty) / 100);
377 dbusmenu_collector_found_set_distance(found, distance);377 menuitem_collector_found_set_distance(found, distance);
378378
379 /* Names */379 /* Names */
380 dbusmenu_collector_found_set_indicator(found, indicator->name);380 menuitem_collector_found_set_indicator(found, indicator->name);
381381
382 /* Icon */382 /* Icon */
383 dbusmenu_collector_found_set_app_icon(found, indicator->icon);383 menuitem_collector_found_set_app_icon(found, indicator->icon);
384384
385 founditem = g_list_next(founditem);385 founditem = g_list_next(founditem);
386 }386 }
@@ -422,10 +422,10 @@
422422
423 const gchar * desktopfile = NULL;423 const gchar * desktopfile = NULL;
424424
425 desktopfile = dbusmenu_collector_found_get_indicator(usage->found);425 desktopfile = menuitem_collector_found_get_indicator(usage->found);
426426
427 if (desktopfile != NULL) {427 if (desktopfile != NULL) {
428 usage->count = usage_tracker_get_usage(search->priv->usage, desktopfile, dbusmenu_collector_found_get_db(usage->found));428 usage->count = usage_tracker_get_usage(search->priv->usage, desktopfile, menuitem_collector_found_get_db(usage->found));
429 } else {429 } else {
430 usage->count = 0;430 usage->count = 0;
431 }431 }
@@ -437,7 +437,7 @@
437 for (count = 0; count < usagedata->len; count++) {437 for (count = 0; count < usagedata->len; count++) {
438 usage_wrapper_t * usage = &g_array_index(usagedata, usage_wrapper_t, count);438 usage_wrapper_t * usage = &g_array_index(usagedata, usage_wrapper_t, count);
439 overall_usage += usage->count;439 overall_usage += usage->count;
440 overall_distance += dbusmenu_collector_found_get_distance(usage->found);440 overall_distance += menuitem_collector_found_get_distance(usage->found);
441 }441 }
442442
443443
@@ -451,7 +451,7 @@
451 usage->percent_usage = 1.0;451 usage->percent_usage = 1.0;
452 }452 }
453453
454 usage->percent_distance = (gfloat)dbusmenu_collector_found_get_distance(usage->found)/(gfloat)overall_distance;454 usage->percent_distance = (gfloat)menuitem_collector_found_get_distance(usage->found)/(gfloat)overall_distance;
455 }455 }
456456
457 /* Sort based on aggregate */457 /* Sort based on aggregate */
@@ -508,19 +508,19 @@
508 for (count = 0; count < 5 && count < usagedata->len; count++) {508 for (count = 0; count < 5 && count < usagedata->len; count++) {
509 usage_wrapper_t * usage = &g_array_index(usagedata, usage_wrapper_t, count);509 usage_wrapper_t * usage = &g_array_index(usagedata, usage_wrapper_t, count);
510510
511 const gchar * desktopfile = dbusmenu_collector_found_get_indicator(usage->found);511 const gchar * desktopfile = menuitem_collector_found_get_indicator(usage->found);
512 if (desktopfile == NULL) {512 if (desktopfile == NULL) {
513 desktopfile = appdesktopfile;513 desktopfile = appdesktopfile;
514 }514 }
515515
516 HudSearchSuggest * suggest = hud_search_suggest_new(desktopfile,516 HudSearchSuggest * suggest = hud_search_suggest_new(desktopfile,
517 dbusmenu_collector_found_get_app_icon(usage->found),517 menuitem_collector_found_get_app_icon(usage->found),
518 dbusmenu_collector_found_get_display(usage->found),518 menuitem_collector_found_get_display(usage->found),
519 dbusmenu_collector_found_get_db(usage->found),519 menuitem_collector_found_get_db(usage->found),
520 "none",520 "none",
521 dbusmenu_collector_found_get_dbus_addr(usage->found),521 menuitem_collector_found_get_dbus_addr(usage->found),
522 dbusmenu_collector_found_get_dbus_path(usage->found),522 menuitem_collector_found_get_dbus_path(usage->found),
523 dbusmenu_collector_found_get_dbus_id(usage->found)523 menuitem_collector_found_get_dbus_id(usage->found)
524 );524 );
525525
526 retval = g_list_prepend(retval, suggest);526 retval = g_list_prepend(retval, suggest);
@@ -530,7 +530,7 @@
530530
531 /* Free the interim arrays of data */531 /* Free the interim arrays of data */
532 g_array_free(usagedata, TRUE);532 g_array_free(usagedata, TRUE);
533 dbusmenu_collector_found_list_free(found_list);533 menuitem_collector_found_list_free(found_list);
534534
535 return retval;535 return retval;
536}536}
@@ -557,7 +557,7 @@
557 }557 }
558558
559 if (app != NULL && dbstring != NULL && address != NULL && path != NULL && id != 0) {559 if (app != NULL && dbstring != NULL && address != NULL && path != NULL && id != 0) {
560 dbusmenu_collector_execute(search->priv->collector, address, path, id, timestamp);560 menuitem_collector_execute(search->priv->collector, address, path, id, timestamp);
561 usage_tracker_mark_usage(search->priv->usage, app, dbstring);561 usage_tracker_mark_usage(search->priv->usage, app, dbstring);
562 }562 }
563563
564564
=== renamed file 'src/dbusmenu-collector.c' => 'src/menuitem-collector.c'
--- src/dbusmenu-collector.c 2012-01-26 16:51:25 +0000
+++ src/menuitem-collector.c 2012-01-26 16:51:25 +0000
@@ -30,23 +30,23 @@
3030
31#include <libdbusmenu-glib/client.h>31#include <libdbusmenu-glib/client.h>
3232
33#include "dbusmenu-collector.h"33#include "menuitem-collector.h"
34#include "distance.h"34#include "distance.h"
35#include "shared-values.h"35#include "shared-values.h"
36#include "utils.h"36#include "utils.h"
3737
38#define GENERIC_ICON "dbusmenu-lens-panel"38#define GENERIC_ICON "dbusmenu-lens-panel"
3939
40typedef struct _DbusmenuCollectorPrivate DbusmenuCollectorPrivate;40typedef struct _MenuitemCollectorPrivate MenuitemCollectorPrivate;
4141
42struct _DbusmenuCollectorPrivate {42struct _MenuitemCollectorPrivate {
43 GDBusConnection * bus;43 GDBusConnection * bus;
44 guint signal;44 guint signal;
45 GHashTable * hash;45 GHashTable * hash;
46 GSettings * search_settings;46 GSettings * search_settings;
47};47};
4848
49struct _DbusmenuCollectorFound {49struct _MenuitemCollectorFound {
50 gchar * dbus_addr;50 gchar * dbus_addr;
51 gchar * dbus_path;51 gchar * dbus_path;
52 gint dbus_id;52 gint dbus_id;
@@ -73,35 +73,35 @@
73 guint distance;73 guint distance;
74};74};
7575
76static void dbusmenu_collector_class_init (DbusmenuCollectorClass *klass);76static void menuitem_collector_class_init (MenuitemCollectorClass *klass);
77static void dbusmenu_collector_init (DbusmenuCollector *self);77static void menuitem_collector_init (MenuitemCollector *self);
78static void dbusmenu_collector_dispose (GObject *object);78static void menuitem_collector_dispose (GObject *object);
79static void dbusmenu_collector_finalize (GObject *object);79static void menuitem_collector_finalize (GObject *object);
80static void update_layout_cb (GDBusConnection * connection, const gchar * sender, const gchar * path, const gchar * interface, const gchar * signal, GVariant * params, gpointer user_data);80static void update_layout_cb (GDBusConnection * connection, const gchar * sender, const gchar * path, const gchar * interface, const gchar * signal, GVariant * params, gpointer user_data);
81static guint menu_hash_func (gconstpointer key);81static guint menu_hash_func (gconstpointer key);
82static gboolean menu_equal_func (gconstpointer a, gconstpointer b);82static gboolean menu_equal_func (gconstpointer a, gconstpointer b);
83static void menu_key_destroy (gpointer key);83static void menu_key_destroy (gpointer key);
84static DbusmenuCollectorFound * dbusmenu_collector_found_new (DbusmenuClient * client, DbusmenuMenuitem * item, GStrv strings, guint distance, GStrv usedstrings, const gchar * indicator_name);84static MenuitemCollectorFound * menuitem_collector_found_new (DbusmenuClient * client, DbusmenuMenuitem * item, GStrv strings, guint distance, GStrv usedstrings, const gchar * indicator_name);
8585
86G_DEFINE_TYPE (DbusmenuCollector, dbusmenu_collector, G_TYPE_OBJECT);86G_DEFINE_TYPE (MenuitemCollector, menuitem_collector, G_TYPE_OBJECT);
8787
88static void88static void
89dbusmenu_collector_class_init (DbusmenuCollectorClass *klass)89menuitem_collector_class_init (MenuitemCollectorClass *klass)
90{90{
91 GObjectClass *object_class = G_OBJECT_CLASS (klass);91 GObjectClass *object_class = G_OBJECT_CLASS (klass);
9292
93 g_type_class_add_private (klass, sizeof (DbusmenuCollectorPrivate));93 g_type_class_add_private (klass, sizeof (MenuitemCollectorPrivate));
9494
95 object_class->dispose = dbusmenu_collector_dispose;95 object_class->dispose = menuitem_collector_dispose;
96 object_class->finalize = dbusmenu_collector_finalize;96 object_class->finalize = menuitem_collector_finalize;
9797
98 return;98 return;
99}99}
100100
101static void101static void
102dbusmenu_collector_init (DbusmenuCollector *self)102menuitem_collector_init (MenuitemCollector *self)
103{103{
104 self->priv = G_TYPE_INSTANCE_GET_PRIVATE ((self), DBUSMENU_COLLECTOR_TYPE, DbusmenuCollectorPrivate);104 self->priv = G_TYPE_INSTANCE_GET_PRIVATE ((self), MENUITEM_COLLECTOR_TYPE, MenuitemCollectorPrivate);
105105
106 self->priv->bus = NULL;106 self->priv->bus = NULL;
107 self->priv->signal = 0;107 self->priv->signal = 0;
@@ -144,9 +144,9 @@
144}144}
145145
146static void146static void
147dbusmenu_collector_dispose (GObject *object)147menuitem_collector_dispose (GObject *object)
148{148{
149 DbusmenuCollector * collector = DBUSMENU_COLLECTOR(object);149 MenuitemCollector * collector = MENUITEM_COLLECTOR(object);
150150
151 if (collector->priv->signal != 0) {151 if (collector->priv->signal != 0) {
152 g_dbus_connection_signal_unsubscribe(collector->priv->bus, collector->priv->signal);152 g_dbus_connection_signal_unsubscribe(collector->priv->bus, collector->priv->signal);
@@ -163,29 +163,29 @@
163 collector->priv->search_settings = NULL;163 collector->priv->search_settings = NULL;
164 }164 }
165165
166 G_OBJECT_CLASS (dbusmenu_collector_parent_class)->dispose (object);166 G_OBJECT_CLASS (menuitem_collector_parent_class)->dispose (object);
167 return;167 return;
168}168}
169169
170static void170static void
171dbusmenu_collector_finalize (GObject *object)171menuitem_collector_finalize (GObject *object)
172{172{
173173
174 G_OBJECT_CLASS (dbusmenu_collector_parent_class)->finalize (object);174 G_OBJECT_CLASS (menuitem_collector_parent_class)->finalize (object);
175 return;175 return;
176}176}
177177
178DbusmenuCollector *178MenuitemCollector *
179dbusmenu_collector_new (void)179menuitem_collector_new (void)
180{180{
181 return DBUSMENU_COLLECTOR(g_object_new(DBUSMENU_COLLECTOR_TYPE, NULL));181 return MENUITEM_COLLECTOR(g_object_new(MENUITEM_COLLECTOR_TYPE, NULL));
182}182}
183183
184static void184static void
185update_layout_cb (GDBusConnection * connection, const gchar * sender, const gchar * path, const gchar * interface, const gchar * signal, GVariant * params, gpointer user_data)185update_layout_cb (GDBusConnection * connection, const gchar * sender, const gchar * path, const gchar * interface, const gchar * signal, GVariant * params, gpointer user_data)
186{186{
187 g_debug("Client updating %s:%s", sender, path);187 g_debug("Client updating %s:%s", sender, path);
188 DbusmenuCollector * collector = DBUSMENU_COLLECTOR(user_data);188 MenuitemCollector * collector = MENUITEM_COLLECTOR(user_data);
189 g_return_if_fail(collector != NULL);189 g_return_if_fail(collector != NULL);
190190
191 menu_key_t search_key = {191 menu_key_t search_key = {
@@ -376,7 +376,7 @@
376 guint distance = calculate_distance(search, newstr, &used_strings);376 guint distance = calculate_distance(search, newstr, &used_strings);
377 if (distance < G_MAXUINT) {377 if (distance < G_MAXUINT) {
378 // g_debug("Distance %d for '%s' in \"'%s'\" using \"'%s'\"", distance, search, g_strjoinv("' '", newstr), g_strjoinv("' '", used_strings));378 // g_debug("Distance %d for '%s' in \"'%s'\" using \"'%s'\"", distance, search, g_strjoinv("' '", newstr), g_strjoinv("' '", used_strings));
379 results = g_list_prepend(results, dbusmenu_collector_found_new(client, rootitem, newstr, distance, used_strings, indicator_name));379 results = g_list_prepend(results, menuitem_collector_found_new(client, rootitem, newstr, distance, used_strings, indicator_name));
380 }380 }
381 g_strfreev(used_strings);381 g_strfreev(used_strings);
382 }382 }
@@ -399,7 +399,7 @@
399}399}
400400
401static GList *401static GList *
402process_client (DbusmenuCollector * collector, DbusmenuClient * client, const gchar * search, GList * results, const gchar * indicator_name, GStrv prefix)402process_client (MenuitemCollector * collector, DbusmenuClient * client, const gchar * search, GList * results, const gchar * indicator_name, GStrv prefix)
403{403{
404 /* Handle the case where there are no search terms */404 /* Handle the case where there are no search terms */
405 if (search == NULL || search[0] == '\0') {405 if (search == NULL || search[0] == '\0') {
@@ -418,7 +418,7 @@
418 array[0] = label;418 array[0] = label;
419 array[1] = NULL;419 array[1] = NULL;
420420
421 results = g_list_prepend(results, dbusmenu_collector_found_new(client, item, (GStrv)array, calculate_distance(NULL, (GStrv)array, NULL), NULL, indicator_name));421 results = g_list_prepend(results, menuitem_collector_found_new(client, item, (GStrv)array, calculate_distance(NULL, (GStrv)array, NULL), NULL, indicator_name));
422 }422 }
423423
424 return results;424 return results;
@@ -439,9 +439,9 @@
439}439}
440440
441static GList *441static GList *
442just_do_it (DbusmenuCollector * collector, const gchar * dbus_addr, const gchar * dbus_path, const gchar * search, GList * results, const gchar * indicator_name, GStrv prefix)442just_do_it (MenuitemCollector * collector, const gchar * dbus_addr, const gchar * dbus_path, const gchar * search, GList * results, const gchar * indicator_name, GStrv prefix)
443{443{
444 g_return_val_if_fail(IS_DBUSMENU_COLLECTOR(collector), results);444 g_return_val_if_fail(IS_MENUITEM_COLLECTOR(collector), results);
445445
446 menu_key_t search_key = {446 menu_key_t search_key = {
447 sender: (gchar *)dbus_addr,447 sender: (gchar *)dbus_addr,
@@ -462,7 +462,7 @@
462}462}
463463
464GList *464GList *
465dbusmenu_collector_search (DbusmenuCollector * collector, const gchar * dbus_addr, const gchar * dbus_path, const gchar * prefix, const gchar * search)465menuitem_collector_search (MenuitemCollector * collector, const gchar * dbus_addr, const gchar * dbus_path, const gchar * prefix, const gchar * search)
466{466{
467 GList * items = NULL;467 GList * items = NULL;
468 GStrv prefixarray = NULL;468 GStrv prefixarray = NULL;
@@ -483,9 +483,9 @@
483}483}
484484
485void485void
486dbusmenu_collector_execute (DbusmenuCollector * collector, const gchar * dbus_addr, const gchar * dbus_path, gint id, guint timestamp)486menuitem_collector_execute (MenuitemCollector * collector, const gchar * dbus_addr, const gchar * dbus_path, gint id, guint timestamp)
487{487{
488 g_return_if_fail(IS_DBUSMENU_COLLECTOR(collector));488 g_return_if_fail(IS_MENUITEM_COLLECTOR(collector));
489489
490 menu_key_t search_key = {490 menu_key_t search_key = {
491 sender: (gchar *)dbus_addr,491 sender: (gchar *)dbus_addr,
@@ -517,14 +517,14 @@
517}517}
518518
519guint519guint
520dbusmenu_collector_found_get_distance (DbusmenuCollectorFound * found)520menuitem_collector_found_get_distance (MenuitemCollectorFound * found)
521{521{
522 g_return_val_if_fail(found != NULL, G_MAXUINT);522 g_return_val_if_fail(found != NULL, G_MAXUINT);
523 return found->distance;523 return found->distance;
524}524}
525525
526void526void
527dbusmenu_collector_found_set_distance (DbusmenuCollectorFound * found, guint distance)527menuitem_collector_found_set_distance (MenuitemCollectorFound * found, guint distance)
528{528{
529 g_return_if_fail(found != NULL);529 g_return_if_fail(found != NULL);
530 found->distance = distance;530 found->distance = distance;
@@ -532,31 +532,31 @@
532}532}
533533
534const gchar *534const gchar *
535dbusmenu_collector_found_get_display (DbusmenuCollectorFound * found)535menuitem_collector_found_get_display (MenuitemCollectorFound * found)
536{536{
537 g_return_val_if_fail(found != NULL, NULL);537 g_return_val_if_fail(found != NULL, NULL);
538 return found->display_string;538 return found->display_string;
539}539}
540540
541const gchar *541const gchar *
542dbusmenu_collector_found_get_db (DbusmenuCollectorFound * found)542menuitem_collector_found_get_db (MenuitemCollectorFound * found)
543{543{
544 g_return_val_if_fail(found != NULL, NULL);544 g_return_val_if_fail(found != NULL, NULL);
545 return found->db_string;545 return found->db_string;
546}546}
547547
548void548void
549dbusmenu_collector_found_list_free (GList * found_list)549menuitem_collector_found_list_free (GList * found_list)
550{550{
551 g_list_free_full(found_list, (GDestroyNotify)dbusmenu_collector_found_free);551 g_list_free_full(found_list, (GDestroyNotify)menuitem_collector_found_free);
552 return;552 return;
553}553}
554554
555static DbusmenuCollectorFound *555static MenuitemCollectorFound *
556dbusmenu_collector_found_new (DbusmenuClient * client, DbusmenuMenuitem * item, GStrv strings, guint distance, GStrv usedstrings, const gchar * indicator_name)556menuitem_collector_found_new (DbusmenuClient * client, DbusmenuMenuitem * item, GStrv strings, guint distance, GStrv usedstrings, const gchar * indicator_name)
557{557{
558 // g_debug("New Found: '%s', %d, '%s'", string, distance, indicator_name);558 // g_debug("New Found: '%s', %d, '%s'", string, distance, indicator_name);
559 DbusmenuCollectorFound * found = g_new0(DbusmenuCollectorFound, 1);559 MenuitemCollectorFound * found = g_new0(MenuitemCollectorFound, 1);
560560
561 g_object_get(client,561 g_object_get(client,
562 DBUSMENU_CLIENT_PROP_DBUS_NAME, &found->dbus_addr,562 DBUSMENU_CLIENT_PROP_DBUS_NAME, &found->dbus_addr,
@@ -631,7 +631,7 @@
631}631}
632632
633void633void
634dbusmenu_collector_found_free (DbusmenuCollectorFound * found)634menuitem_collector_found_free (MenuitemCollectorFound * found)
635{635{
636 g_return_if_fail(found != NULL);636 g_return_if_fail(found != NULL);
637 g_free(found->dbus_addr);637 g_free(found->dbus_addr);
@@ -646,7 +646,7 @@
646}646}
647647
648const gchar *648const gchar *
649dbusmenu_collector_found_get_indicator (DbusmenuCollectorFound * found)649menuitem_collector_found_get_indicator (MenuitemCollectorFound * found)
650{650{
651 // g_debug("Getting indicator for found '%s', indicator: '%s'", found->display_string, found->indicator);651 // g_debug("Getting indicator for found '%s', indicator: '%s'", found->display_string, found->indicator);
652 g_return_val_if_fail(found != NULL, NULL);652 g_return_val_if_fail(found != NULL, NULL);
@@ -654,7 +654,7 @@
654}654}
655655
656void656void
657dbusmenu_collector_found_set_indicator (DbusmenuCollectorFound * found, const gchar * indicator)657menuitem_collector_found_set_indicator (MenuitemCollectorFound * found, const gchar * indicator)
658{658{
659 g_return_if_fail(found != NULL);659 g_return_if_fail(found != NULL);
660 g_free(found->indicator);660 g_free(found->indicator);
@@ -663,35 +663,35 @@
663}663}
664664
665const gchar *665const gchar *
666dbusmenu_collector_found_get_dbus_addr (DbusmenuCollectorFound * found)666menuitem_collector_found_get_dbus_addr (MenuitemCollectorFound * found)
667{667{
668 g_return_val_if_fail(found != NULL, NULL);668 g_return_val_if_fail(found != NULL, NULL);
669 return found->dbus_addr;669 return found->dbus_addr;
670}670}
671671
672const gchar *672const gchar *
673dbusmenu_collector_found_get_dbus_path (DbusmenuCollectorFound * found)673menuitem_collector_found_get_dbus_path (MenuitemCollectorFound * found)
674{674{
675 g_return_val_if_fail(found != NULL, NULL);675 g_return_val_if_fail(found != NULL, NULL);
676 return found->dbus_path;676 return found->dbus_path;
677}677}
678678
679gint679gint
680dbusmenu_collector_found_get_dbus_id (DbusmenuCollectorFound * found)680menuitem_collector_found_get_dbus_id (MenuitemCollectorFound * found)
681{681{
682 g_return_val_if_fail(found != NULL, -1);682 g_return_val_if_fail(found != NULL, -1);
683 return found->dbus_id;683 return found->dbus_id;
684}684}
685685
686const gchar *686const gchar *
687dbusmenu_collector_found_get_app_icon (DbusmenuCollectorFound * found)687menuitem_collector_found_get_app_icon (MenuitemCollectorFound * found)
688{688{
689 g_return_val_if_fail(found != NULL, NULL);689 g_return_val_if_fail(found != NULL, NULL);
690 return found->app_icon;690 return found->app_icon;
691}691}
692692
693void693void
694dbusmenu_collector_found_set_app_icon (DbusmenuCollectorFound * found, const gchar * app_icon)694menuitem_collector_found_set_app_icon (MenuitemCollectorFound * found, const gchar * app_icon)
695{695{
696 g_return_if_fail(found != NULL);696 g_return_if_fail(found != NULL);
697 g_free(found->app_icon);697 g_free(found->app_icon);
698698
=== renamed file 'src/dbusmenu-collector.h' => 'src/menuitem-collector.h'
--- src/dbusmenu-collector.h 2012-01-26 16:51:25 +0000
+++ src/menuitem-collector.h 2012-01-26 16:51:25 +0000
@@ -20,54 +20,54 @@
20with this program. If not, see <http://www.gnu.org/licenses/>.20with this program. If not, see <http://www.gnu.org/licenses/>.
21*/21*/
2222
23#ifndef __DBUSMENU_COLLECTOR_H__23#ifndef __MENUITEM_COLLECTOR_H__
24#define __DBUSMENU_COLLECTOR_H__24#define __MENUITEM_COLLECTOR_H__
2525
26#include <glib.h>26#include <glib.h>
27#include <glib-object.h>27#include <glib-object.h>
2828
29G_BEGIN_DECLS29G_BEGIN_DECLS
3030
31#define DBUSMENU_COLLECTOR_TYPE (dbusmenu_collector_get_type ())31#define MENUITEM_COLLECTOR_TYPE (menuitem_collector_get_type ())
32#define DBUSMENU_COLLECTOR(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), DBUSMENU_COLLECTOR_TYPE, DbusmenuCollector))32#define MENUITEM_COLLECTOR(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), MENUITEM_COLLECTOR_TYPE, MenuitemCollector))
33#define DBUSMENU_COLLECTOR_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), DBUSMENU_COLLECTOR_TYPE, DbusmenuCollectorClass))33#define MENUITEM_COLLECTOR_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), MENUITEM_COLLECTOR_TYPE, MenuitemCollectorClass))
34#define IS_DBUSMENU_COLLECTOR(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), DBUSMENU_COLLECTOR_TYPE))34#define IS_MENUITEM_COLLECTOR(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), MENUITEM_COLLECTOR_TYPE))
35#define IS_DBUSMENU_COLLECTOR_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), DBUSMENU_COLLECTOR_TYPE))35#define IS_MENUITEM_COLLECTOR_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), MENUITEM_COLLECTOR_TYPE))
36#define DBUSMENU_COLLECTOR_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), DBUSMENU_COLLECTOR_TYPE, DbusmenuCollectorClass))36#define MENUITEM_COLLECTOR_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), MENUITEM_COLLECTOR_TYPE, MenuitemCollectorClass))
3737
38typedef struct _DbusmenuCollector DbusmenuCollector;38typedef struct _MenuitemCollector MenuitemCollector;
39typedef struct _DbusmenuCollectorClass DbusmenuCollectorClass;39typedef struct _MenuitemCollectorClass MenuitemCollectorClass;
40typedef struct _DbusmenuCollectorPrivate DbusmenuCollectorPrivate;40typedef struct _MenuitemCollectorPrivate MenuitemCollectorPrivate;
41typedef struct _DbusmenuCollectorFound DbusmenuCollectorFound;41typedef struct _MenuitemCollectorFound MenuitemCollectorFound;
4242
43struct _DbusmenuCollectorClass {43struct _MenuitemCollectorClass {
44 GObjectClass parent_class;44 GObjectClass parent_class;
45};45};
4646
47struct _DbusmenuCollector {47struct _MenuitemCollector {
48 GObject parent;48 GObject parent;
4949
50 DbusmenuCollectorPrivate * priv;50 MenuitemCollectorPrivate * priv;
51};51};
5252
53GType dbusmenu_collector_get_type (void);53GType menuitem_collector_get_type (void);
54DbusmenuCollector * dbusmenu_collector_new (void);54MenuitemCollector * menuitem_collector_new (void);
55GList * dbusmenu_collector_search (DbusmenuCollector * collector, const gchar * dbus_addr, const gchar * dbus_path, const gchar * prefix, const gchar * search);55GList * menuitem_collector_search (MenuitemCollector * collector, const gchar * dbus_addr, const gchar * dbus_path, const gchar * prefix, const gchar * search);
56void dbusmenu_collector_execute (DbusmenuCollector * collector, const gchar * dbus_addr, const gchar * dbus_path, gint id, guint timestamp);56void menuitem_collector_execute (MenuitemCollector * collector, const gchar * dbus_addr, const gchar * dbus_path, gint id, guint timestamp);
5757
58guint dbusmenu_collector_found_get_distance (DbusmenuCollectorFound * found);58guint menuitem_collector_found_get_distance (MenuitemCollectorFound * found);
59void dbusmenu_collector_found_set_distance (DbusmenuCollectorFound * found, guint distance);59void menuitem_collector_found_set_distance (MenuitemCollectorFound * found, guint distance);
60const gchar * dbusmenu_collector_found_get_display (DbusmenuCollectorFound * found);60const gchar * menuitem_collector_found_get_display (MenuitemCollectorFound * found);
61const gchar * dbusmenu_collector_found_get_db (DbusmenuCollectorFound * found);61const gchar * menuitem_collector_found_get_db (MenuitemCollectorFound * found);
62void dbusmenu_collector_found_free (DbusmenuCollectorFound * found);62void menuitem_collector_found_free (MenuitemCollectorFound * found);
63void dbusmenu_collector_found_list_free (GList * found_list);63void menuitem_collector_found_list_free (GList * found_list);
64const gchar * dbusmenu_collector_found_get_indicator (DbusmenuCollectorFound * found);64const gchar * menuitem_collector_found_get_indicator (MenuitemCollectorFound * found);
65void dbusmenu_collector_found_set_indicator (DbusmenuCollectorFound * found, const gchar * indicator);65void menuitem_collector_found_set_indicator (MenuitemCollectorFound * found, const gchar * indicator);
66const gchar * dbusmenu_collector_found_get_dbus_addr (DbusmenuCollectorFound * found);66const gchar * menuitem_collector_found_get_dbus_addr (MenuitemCollectorFound * found);
67const gchar * dbusmenu_collector_found_get_dbus_path (DbusmenuCollectorFound * found);67const gchar * menuitem_collector_found_get_dbus_path (MenuitemCollectorFound * found);
68gint dbusmenu_collector_found_get_dbus_id (DbusmenuCollectorFound * found);68gint menuitem_collector_found_get_dbus_id (MenuitemCollectorFound * found);
69const gchar * dbusmenu_collector_found_get_app_icon (DbusmenuCollectorFound * found);69const gchar * menuitem_collector_found_get_app_icon (MenuitemCollectorFound * found);
70void dbusmenu_collector_found_set_app_icon (DbusmenuCollectorFound * found, const gchar * app_icon);70void menuitem_collector_found_set_app_icon (MenuitemCollectorFound * found, const gchar * app_icon);
7171
72G_END_DECLS72G_END_DECLS
7373

Subscribers

People subscribed via source and target branches