Code review comment for lp:~ted/indicator-appmenu/db-now-with-indexes

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

72 create table usage (application text, entry text, timestamp datetime);
73 +create index if not exists application_index on usage (application);

You might want to also 'create table if not exists ...' for the main table.

143 === modified file 'tests/test-usage-db-ancient.c'
144 --- tests/test-usage-db-ancient.c 2012-01-25 20:43:26 +0000
145 +++ tests/test-usage-db-ancient.c 2012-01-25 20:43:27 +0000
146 @@ -27,6 +27,7 @@
147 #include "usage-tracker.h"
148 #include "usage-tracker.c"
149 #include "utils.c"
150 +#include "create-db.c"

Is it not #include "create-db.h". That is s/.c/.h/ ? Same for all test files.

« Back to merge proposal