Merge lp:~ted/indicator-application/lp944236 into lp:indicator-application/0.5

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 223
Merge reported by: Charles Kerr
Merged at revision: not available
Proposed branch: lp:~ted/indicator-application/lp944236
Merge into: lp:indicator-application/0.5
Diff against target: 28 lines (+10/-1)
1 file modified
src/application-service-appstore.c (+10/-1)
To merge this branch: bzr merge lp:~ted/indicator-application/lp944236
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+95691@code.launchpad.net

Description of the change

Fix a switch statement that was a bit ugly, now beautiful!

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

Gorgeous!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/application-service-appstore.c'
--- src/application-service-appstore.c 2012-03-02 05:16:38 +0000
+++ src/application-service-appstore.c 2012-03-02 23:06:19 +0000
@@ -284,14 +284,23 @@
284 switch (direction) {284 switch (direction) {
285 case INDICATOR_OBJECT_SCROLL_UP:285 case INDICATOR_OBJECT_SCROLL_UP:
286 delta = -delta;286 delta = -delta;
287 orientation = "vertical";
288 break;
287 case INDICATOR_OBJECT_SCROLL_DOWN:289 case INDICATOR_OBJECT_SCROLL_DOWN:
290 /* delta unchanged */
288 orientation = "vertical";291 orientation = "vertical";
289 break;292 break;
290
291 case INDICATOR_OBJECT_SCROLL_LEFT:293 case INDICATOR_OBJECT_SCROLL_LEFT:
292 delta = -delta;294 delta = -delta;
295 orientation = "horizontal";
296 break;
293 case INDICATOR_OBJECT_SCROLL_RIGHT:297 case INDICATOR_OBJECT_SCROLL_RIGHT:
298 /* delta unchanged */
294 orientation = "horizontal";299 orientation = "horizontal";
300 break;
301 default:
302 g_assert_not_reached();
303 break;
295 }304 }
296305
297 app = find_application_by_menu(service, dbusaddress, dbusmenuobject);306 app = find_application_by_menu(service, dbusaddress, dbusmenuobject);

Subscribers

People subscribed via source and target branches