Code review comment for lp:~ted/indicator-applet/messages-blacklist

On Fri, 2009-08-21 at 13:46 +0000, David Barth wrote:
> * What's the spurious blacklist_remove (NULL) at the
> end of blacklist_add?

Compiler complains if there are functions that aren't used, but static.
And I wanted to have the prototype in there. It'll be removed when the
function does something :)

> * No support yet for removing an item from the blacklist?
> That can be landed later, though.

Yeah, since there is no directory monitoring, there is no one who can
remove things right now. That will be with the directory monitoring
branch (next)

> * Nice use of the g_idle_add; i assume this is for when the
> blacklist will be dynamically edited by the user. Monitoring
> the directory, like for launchers?

Exactly. So the idea is that we can use the same functions when we have
files popup and disappear.