Code review comment for lp:~ted/indicator-applet/messages-blacklist

Revision history for this message
David Barth (dbarth) wrote :

Looks good.

Some questions / remarks:
 * What's the spurious blacklist_remove (NULL) at the end of blacklist_add?
 * No support yet for removing an item from the blacklist? That can be landed later, though.
 * Nice use of the g_idle_add; i assume this is for when the blacklist will be dynamically edited by the user. Monitoring the directory, like for launchers?

review: Needs Information

« Back to merge proposal