Code review comment for lp:~ted/indicator-applet/dynamic-allocation

On Wed, 2009-11-25 at 21:51 +0000, Robert Collins wrote:
> On Wed, 2009-11-25 at 21:27 +0000, Ted Gould wrote:
> > + if (entry->image != NULL) {
> > > > + gtk_box_pack_start(GTK_BOX(hbox),
> > > > GTK_WIDGET(entry->image), FALSE, FALSE, 0);
>
> re: datatypes - you have those, don't you? (GTK_WIDGET, GTK_BOX, ..) Or
> does GTK_WIDGET barf on NULL ? (in which case
> GTK_WIDGET_NULL(entry->image);)

I don't believe that GTK_WIDGET will barf. I believe it just returns
NULL. Which (I haven't looked, but I'm pretty confident in) will cause
gtk_box_pack_start() to throw a warning/error. Which we can't catch and
not print because, well, it's C :)

  --Ted