Code review comment for lp:~ted/hud/context-api

Revision history for this message
Ted Gould (ted) wrote :

On Fri, 2013-03-29 at 14:21 +0000, Antti Kaijanmäki wrote:

> we don't need HUD_ACTION_PUBLISHER_NO_CONTEXT anymore. We can just document that when a NULL is passed then the context id is automatically generated.

I'd prefer to do both. In that I think it makes the code more readable
to not have "0"s and "NULL"s as function parameters. I don't think it
hurts anything to leave it in.

> Are we missing some commits from this repo? Commits mentioned in these comments seem to be missing:
> https:��code.launchpad.net�~ted�hud�context-api�+merge�155596�comments�340267
> https:��code.launchpad.net�~ted�hud�context-api�+merge�155596�comments�340269

No clue. Looked all over, can't find them. Just redid them. They
should be there now.

« Back to merge proposal