Code review comment for lp:~ted/hud/context-api

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

> On Thu, 2013-03-28 at 13:58 +0000, Antti Kaijanmäki wrote:
>
> > OK, but say I create 3 action publishers with
> > HUD_ACTION_PUBLISHER_NO_CONTEXT. How do I switch between them if they
> > don't have context Ids?
>
>
> Uhm, don't do that? :-)
>
> I mean, an action publisher represents a context. If there's only one
> context on a window, you can pass no context, if there's more you need
> to provide context IDs or it's an error.

Yes, OK. So this relates back to the "who should generate all these IDs" discussion we had earlier. IMHO the app developer should not have to care about the context ID (or generate it). All he would need to do is create a new ActionPublisher and if he chooses not to generate the context ID then it should be generated by libhud. So if the developer passes NULL as a context Id then action_publisher_new() would generate one. Do we actually need action publishers with context id set to NULL anyway?

« Back to merge proposal