Code review comment for lp:~ted/hud/context-api

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

> 171 +void hud_manager_switch_window_context (HudManager * manager,
> 172 + guint windowid,
> 173 + const gchar * new_context);
>
> as the action description already contains the windowId and contextId how
> about changing the signature of this function to
> hud_manager_switch_window_context (HudManager * manager, HudActionPublisher
> *publisher) ?

Also, windowId and contextId should be properties of the HudActionPublisher. You can access them through the build_id() but that is a bit clumsy.

« Back to merge proposal